Add optional UID argument to bosh-enable-monit-access command#416
Closed
Add optional UID argument to bosh-enable-monit-access command#416
Conversation
selzoc
reviewed
Feb 28, 2026
platform/firewall/monit_access.go
Outdated
| ) | ||
|
|
||
| func EnableMonitAccess(logger boshlog.Logger, command string) { | ||
| func EnableMonitAccess(logger boshlog.Logger, command string, args []string) { |
Member
There was a problem hiding this comment.
Why a slice of args and not just the first one as uid?
mariash
force-pushed
the
add-uid-arg
branch
4 times, most recently
from
0ef9020 to
717b64f
Compare
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Member
|
I wonder if we should just hardcode the That's essentially what's being proposed in cloudfoundry/bosh-linux-stemcell-builder#481 but can be made more explicit in the bosh-agent code, leaving |
Member
Author
|
Closing this one in favor of #417. Using cgroups is preferred over UID |
github-project-automation
bot
moved this from Inbox
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional UID argument to bosh-enable-monit-access command