Fix issue: PAT panics if there are any unexpected files in output/csvs/ #114#126
Fix issue: PAT panics if there are any unexpected files in output/csvs/ #114#126krishnamk00 wants to merge 4 commits into
Conversation
|
Hey krishna-mk! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
Hey, this looks like a neat idea, but the way you implemented it seems kind of brittle - it just checks all the files that happen to have a hyphen in the name. Wouldn't it be a better idea to try and grab all files that match the ----*.csv pattern that PAT outputs? You also didn't include a test for the feature. |
…shna-mk/pat into krishna-mk-OutputdirPanicFix Conflicts: store/csv.go
|
Hi Jo, I added .csv file check and the test code to validate . So far looks good in my run, If any output file with no .csv and or any other format, those files will be ignored. The PAT getting panic if any arbitrary file in the output/csvs folder is no more an issue. Let me know if you think any more additions to this fix. I will work on other fixes too. - thanks : Krishna |
3 participants
PAT panics if there are any unexpected files in output/csvs. This is because PAT is looking for standard file format it those items. Added a fix to ignore those elements and avoid the panic. There can be custom file created there from "logging:file" parameter passed and so that check is not always applicable to all files.