[miniflare] Scope Durable Object and Workflow local explorer peers by storageScope - #15527
Open
devaniketh wants to merge 2 commits into
Open
[miniflare] Scope Durable Object and Workflow local explorer peers by storageScope#15527devaniketh wants to merge 2 commits into
devaniketh wants to merge 2 commits into
Conversation
… storageScope Scope Durable Object and Workflow peer aggregation and owner resolution in the Miniflare local explorer to peers sharing the same storageScope when Shared Storage is enabled. This brings DO and Workflow exploration into alignment with KV, D1, and R2 behavior and prevents cross-project access to local development state across instances configured with different persistence roots. Fixes cloudflare#15479
🦋 Changeset detectedLatest commit: 950800a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
emily-shen
and removed request for
a team
September 6, 2026 03:28
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
…eer aggregation Pass getKey: (namespace) => namespace.id to aggregateListResults for DO namespaces, preventing duplicate entries when same-scope peers advertise matching namespaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15479.
Scope Durable Object and Workflow peer aggregation and owner resolution in the Miniflare local explorer to peers sharing the same storageScope when Shared Storage is enabled.
In the local explorer, KV, D1, and R2 scoped peer aggregation to instances sharing the same
storageScope. Durable Objects and Workflows previously omitted{ sharedStorageOnly: true }, allowing peer instances with differing storage scopes to advertise their DOs and Workflows to each other.This change passes
{ sharedStorageOnly: true }togetPeerUrlsIfAggregatingandaggregateListResultsfor DOs and Workflows, ensuring consistency across all resource explorers and preventing cross-scope contamination in local development.