[vite-plugin-cloudflare] fix: preserve :authority and port in HTTP/2 requests - #15519
Open
devaniketh wants to merge 2 commits into
Open
[vite-plugin-cloudflare] fix: preserve :authority and port in HTTP/2 requests#15519devaniketh wants to merge 2 commits into
devaniketh wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 18d4715 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
dario-piotrowicz
and removed request for
a team
September 5, 2026 03:17
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Author
|
@dario-piotrowicz hey can you look into the PR , let me know if there are any changes to made |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14931.
When Vite dev server is served over HTTPS with HTTP/2 enabled, browsers communicate using HTTP/2 where the host and port are passed via the
:authoritypseudo-header rather than the HTTP/1.1Hostheader.Previously, request conversion in
createRequestForIncomingMessageomitted pseudo-headers when creating the Web StandardRequest, causingheaders.get("Host")to benulland falling back to"localhost", discarding non-default ports (such as:5173). Consequently,X-Forwarded-Hostwas not set intoMiniflareRequest, breaking OAuth and Clerk handshake redirects.This change:
req.headers[":authority"]andreq.authority.req.headers[":scheme"]andreq.scheme.Hostheader is populated on the createdRequest.new URL(request.url).hostintoMiniflareRequestto guaranteeX-Forwarded-Hostpreserves the host and port.