[wrangler] Preserve D1 migration paths during redirected provisioning - #15517
Draft
xgame92 wants to merge 1 commit into
Draft
[wrangler] Preserve D1 migration paths during redirected provisioning#15517xgame92 wants to merge 1 commit into
xgame92 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: fdc6ad1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
Author
|
CI note: the only failing check is Vite Plugin Playground (windows-latest, vite-8), where the unrelated react-spa experimental headers/redirects suite timed out in beforeAll after the matrix had completed 94 suites / 287 tests. I reproduced that exact suite locally on Windows with Vite 8.1.5 after building the plugin: 1 file passed, with 6 passing and 3 expected-failure tests, in 8.39s. I cannot rerun the GitHub job because failed-job reruns require repository admin permission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15484.
When deployments use a redirected config, resource provisioning currently writes the complete generated binding back to the original user config. Generated configs can contain paths rebased relative to their own location, so provisioning a D1 database through the Vite plugin replaces a user-authored
migrations_dirwith a path that is invalid in the source config.This changes redirected writeback to start from the original binding and overlay only the newly provisioned resource identifier. Non-redirected writeback remains unchanged, and bindings injected only by the redirected config are still excluded.
Tests:
pnpm --dir packages/wrangler test:ci src/__tests__/provision.test.tspnpm --dir packages/deploy-helpers check:typepnpm --dir packages/wrangler check:typeA picture of a cute animal (not mandatory, but encouraged)