Skip to content

Vite plugin v2 - Use printBindings from workers-utils #15508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesopstad wants to merge 1 commit into from
+9 −7
Open

Vite plugin v2 - Use printBindings from workers-utils #15508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/vite-plugin-cloudflare/src/plugins/shortcuts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
import { convertToWranglerConfig } from "@cloudflare/config";
import {
convertConfigToBindings,
printBindings,
} from "@cloudflare/workers-utils";
import {
CorePaths,
getDefaultDevRegistryPath,
getWorkerRegistry,
} from "miniflare";
import open from "open";
import colors from "picocolors";
import * as wrangler from "wrangler";
import { assertIsNotPreview, assertIsPreview } from "../context";
import { createPlugin, satisfiesMinimumViteVersion } from "../utils";
import { extendTunnelExpiry, isTunnelOpen, toggleTunnel } from "./tunnel";
Expand Down Expand Up @@ -57,22 +60,21 @@ export function addShortcuts(

for (const workerConfig of workerConfigs) {
const wranglerConfig = convertToWranglerConfig(workerConfig);
const bindings =
wrangler.unstable_convertConfigBindingsToStartWorkerBindings(
wranglerConfig
);
const bindings = convertConfigToBindings(wranglerConfig, {
usePreviewIds: true,
});

// TODO: Include Containers when they are supported by
// cloudflare.config.ts.
wrangler.unstable_printBindings(bindings, {
printBindings(bindings, {
tailConsumers: wranglerConfig.tail_consumers,
streamingTailConsumers: wranglerConfig.streaming_tail_consumers,
containers: wranglerConfig.containers,
warnIfNoBindings: true,
isMultiWorker: workerConfigs.length > 1,
name: workerConfig.name ?? "Your Worker",
registry: getWorkerRegistry(registryPath),
log: (message: string) => viteServer.config.logger.info(message),
log: (message) => viteServer.config.logger.info(message),
});
}
},
Expand Down
Loading