Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions engine/src/ast/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -306,13 +306,13 @@ impl FilterValueAst {
/// Recursively visit all nodes in the AST using a [`Visitor`].
#[inline]
pub fn walk<'a, V: Visitor<'a>>(&'a self, visitor: &mut V) {
visitor.visit_value_expr(&self.op)
visitor.visit_filter_value_expr(&self.op)
}

/// Recursively visit all nodes in the AST using a [`VisitorMut`].
#[inline]
pub fn walk_mut<'a, V: VisitorMut<'a>>(&'a mut self, visitor: &mut V) {
visitor.visit_value_expr(&mut self.op)
visitor.visit_filter_value_expr(&mut self.op)
}

/// Recursively checks whether a [`FilterAst`] uses a given field name.
Expand Down
14 changes: 13 additions & 1 deletion engine/src/ast/visitor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use super::field_expr::{ComparisonExpr, ComparisonOpExpr};
use super::function_expr::{FunctionCallArgExpr, FunctionCallExpr};
use super::index_expr::IndexExpr;
use super::logical_expr::LogicalExpr;
use super::{Expr, ValueExpr};
use super::{Expr, FilterValueExpr, ValueExpr};
use crate::{Field, FieldRef, Function};

/// Trait used to immutably visit all nodes in the AST.
Expand Down Expand Up @@ -35,6 +35,12 @@ pub trait Visitor<'a>: Sized {
node.walk(self)
}

/// Visit [`FilterValueExpr`] node.
#[inline]
fn visit_filter_value_expr(&mut self, node: &'a FilterValueExpr) {
self.visit_value_expr(node)
}

/// Visit [`IndexExpr`] node.
#[inline]
fn visit_index_expr(&mut self, node: &'a IndexExpr) {
Expand Down Expand Up @@ -100,6 +106,12 @@ pub trait VisitorMut<'a>: Sized {
node.walk_mut(self)
}

/// Visit [`FilterValueExpr`] node.
#[inline]
fn visit_filter_value_expr(&mut self, node: &'a mut FilterValueExpr) {
self.visit_value_expr(node)
}

/// Visit [`IndexExpr`] node.
#[inline]
fn visit_index_expr(&mut self, node: &'a mut IndexExpr) {
Expand Down
Loading