fix: clean up request context on stream error in deferUntilStreamConsumed#760
Open
NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
Open
fix: clean up request context on stream error in deferUntilStreamConsumed#760NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
Conversation
…umed deferUntilStreamConsumed's pull() handler had no error path — when the upstream RSC/SSR stream errored mid-consumption, the onFlush callback (clearRequestContext) was never invoked, leaking per-request state. The cancel hook handled client disconnect and the flush hook handled normal completion, but stream errors were uncovered. Adds an error handler that calls once() before propagating the error.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deferUntilStreamConsumed'spull()handler had no error path for upstream stream errorsclearRequestContext()was never called, leaking per-request state (headers, cookies, navigation context)Test plan