fix: preserve multi-valued Set-Cookie headers in route handler ISR cache#758
Open
NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
Open
fix: preserve multi-valued Set-Cookie headers in route handler ISR cache#758NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
NathanDrake2406 wants to merge 1 commit intocloudflare:mainfrom
Conversation
buildAppRouteCacheValue() used headers.forEach() which overwrites same-key entries, causing all but the last Set-Cookie header to be silently dropped from cached route handler responses. Uses getSetCookie() to preserve all Set-Cookie headers as a string array, matching the pattern used elsewhere in the codebase (worker-utils.ts, prod-server.ts).
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildAppRouteCacheValue()usedheaders.forEach()which overwrites same-key entries, dropping all but the lastSet-Cookieheader from cached responsesbuildRouteHandlerCachedResponse) already handlesstring[]correctly — only the store path was brokengetSetCookie()to preserve all Set-Cookie headers as astring[], matching the pattern inworker-utils.tsandprod-server.tsTest plan