Skip to content

Peter - #233

Open
ElRadarNocturno wants to merge 2227 commits into
cloudflare:keep_original_connectfrom
ElRadarNocturno:main
Open

Peter #233
ElRadarNocturno wants to merge 2227 commits into
cloudflare:keep_original_connectfrom
ElRadarNocturno:main

Conversation

@ElRadarNocturno

Copy link
Copy Markdown

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

release-please Bot and others added 30 commits June 12, 2024 10:41
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…he all group (#12592)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ith 9 updates (#12597)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
Co-authored-by: Nikolay Vitkov <nvitkov@chromium.org>
Co-authored-by: Alex Rudenko <alexrudenko@chromium.org>
…2600)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ruifigueira and others added 26 commits February 1, 2026 18:41
This scheduled workflow was inherited from the upstream puppeteer/puppeteer
fork and serves no purpose for the Cloudflare fork:

- Tests upstream Puppeteer compatibility with Chrome Canary (not relevant)
- Reports results to upstream issue puppeteer/puppeteer#12379 (no write access)
- All 359 runs have failed, burning ~240 GitHub Actions minutes daily
- Generates daily failure notification emails with no signal
chore: remove Puppeteer Canary CI workflow
workerd made websocket_standard_binary_type default and that broke our binary message handling.

However, we no longer need the chunking logic as the browser binding now supports CDP protocol, so we can just remove the binary chunking bits.

Fixes: cloudflare#193
Updates user-facing references from Browser Rendering to Browser Run:
- README.md: title, CDP section, bridge phrasing
- packages/puppeteer-core/package.json: description field

Part of the Browser Run rename (Agents Week 2026).

beep-boop-🤖
…er-run

Rename Browser Rendering to Browser Run in README and package.json
Declares the request/response types for Cloudflare's custom CDP domain
(handoff, handoffComplete, getHandoffState, getSessionId, getLiveView)
and merges them into ProtocolMapping.Commands so calls like
session.send('Cloudflare.handoff', {...}) type-check with full param and
return-type inference.

The shared interface block is the canonical definition, vendored
identically into the puppeteer and playwright forks; it is intended to be
promoted to a shared package once the cloudflare/browser-run monorepo
lands. Only the ProtocolMapping augmentation is fork-specific.

BRAPI-1194, BRAPI-1218
The top-level import was unused (the declare-module augmentation declares
its own ProtocolMapping namespace and doesn't reference it), tripping the
repo's noUnusedLocals tsc check. The augmentation merges via the module
specifier alone, so the import is unnecessary.
- GetSessionIdRequest: use Record<string, never> instead of an empty
  interface (@typescript-eslint/no-empty-interface)
- scope an eslint-disable for no-namespace on the ProtocolMapping
  augmentation (augmenting devtools-protocol's namespace requires a
  namespace to match its declaration)
Line 236 used '{ method: 'POST' }' with inner spaces, violating the repo's
bracketSpacing:false (gts) config. This pre-dates and is unrelated to this
branch but fails the required lint check; included so this PR's CI can go
green.
prettier --check . fails on main for three files unrelated to this
branch (double-quoted workflow names, missing trailing newline in
package.json). These block the required Inspect code check, so they are
corrected here (via the repo's own prettier --write) to get this PR green.

- .github/workflows/cf_test_full.yml
- .github/workflows/cf_test_smoke.yml
- packages/puppeteer-core/package.json
The module augmentation in protocol.ts was being stripped by API Extractor
when bundling types.d.ts. Fix by:

- Add standalone cloudflare-protocol.d.ts with the ProtocolMapping augmentation
- Inject triple-slash reference into types.d.ts during build
- Export Cloudflare protocol types from index-browser.ts
feat(cloudflare): typed Cloudflare.* CDP commands (handoff, session, live view)
…sted-publishing

Enable trusted publishing of packages
@ElRadarNocturno

Copy link
Copy Markdown
Author

cerrar solicitud de extracción

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.