chore(deps): bump ws to 8.20.1 (GHSA-58qx-3vcg-4xpx) - #209
Open
sassyconsultingllc wants to merge 1 commit into
Open
chore(deps): bump ws to 8.20.1 (GHSA-58qx-3vcg-4xpx)#209sassyconsultingllc wants to merge 1 commit into
sassyconsultingllc wants to merge 1 commit into
Conversation
Bumps `ws` from `^8.18.0` to `^8.20.1` in `packages/puppeteer-core` (@cloudflare/puppeteer) and from `8.18.0` to `8.20.1` in `packages/testserver` (@pptr/testserver). The patched range addresses GHSA-58qx-3vcg-4xpx (CVE-2026-45736), an uninitialized memory disclosure in `WebSocket.close()` when a `TypedArray` is passed as the `reason` argument. Fixed upstream in ws@8.20.1 (websockets/ws@c0327ec). Both packages already declared a compatible range, but pinning the floor at 8.20.1 ensures every fresh install of @cloudflare/puppeteer resolves to a patched ws regardless of consumer lockfile staleness. package-lock.json regenerated via `npm install --package-lock-only`.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the ws dependency version across packages to a newer 8.x release.
Changes:
- Bumped
wsinpackages/testserverfrom8.18.0to8.20.1 - Bumped
wsinpackages/puppeteer-corefrom^8.18.0to^8.20.1
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/testserver/package.json | Updates pinned ws dependency to 8.20.1 |
| packages/puppeteer-core/package.json | Updates ws semver range to start at 8.20.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Security dependency bump.
Did you add tests for your changes?
No — dependency-only patch bump.
ws@8.20.1is a security-only release with no API or behavior change (upstream release notes).If relevant, did you update the documentation?
Not applicable — no user-facing change.
Summary
Bumps
wsto8.20.1to address GHSA-58qx-3vcg-4xpx / CVE-2026-45736 — an uninitialized memory disclosure inWebSocket.close()when aTypedArrayis passed as thereasonargument. The vulnerability affects ws>=8.0.0 <8.20.1. Fixed upstream inws@8.20.1(commitc0327ec).Two packages here declared
wswith a^8.18.0/8.18.0constraint that resolves to the vulnerable version in stale lockfiles:packages/puppeteer-core(@cloudflare/puppeteer):^8.18.0→^8.20.1packages/testserver(@pptr/testserver):8.18.0→8.20.1Although the existing caret on
puppeteer-corealready allows8.20.1via semver, bumping the floor guarantees that every fresh install of@cloudflare/puppeteerresolves to a patchedwseven when a downstream lockfile pre-dates the upstream release. This is the same pattern Cloudflare'sworkers-sdkis applying for the same advisory.package-lock.jsonregenerated vianpm install --package-lock-only. After the bump, bothpackages/puppeteer-core/node_modules/wsandpackages/testserver/node_modules/wsresolve to8.20.1.Does this PR introduce a breaking change?
No —
ws@8.20.1release notes confirm the change is security-only with no API or behavior differences. Consumers using@cloudflare/puppeteerneed no migration.Other information
Related downstream PR for the same advisory in Cloudflare's monorepo: cloudflare/workers-sdk#13978.