Merged
Conversation
thibmeu
force-pushed
the
arbitrary-batched-tokens
branch
from
5d318af to
d6a6224
Compare
thibmeu
changed the title
Contributor
Author
|
EDIT: I have updated the test vectors, the go implementation, and this implementation to use RFC 9000 varint. I have published the varint implementation as a dedicated package quicvarint, it's quite self contained. |
thibmeu
force-pushed
the
arbitrary-batched-tokens
branch
2 times, most recently
from
f178a4d to
b3b7563
Compare
mendess
approved these changes
Mar 5, 2025
Tests are passing test vectors I have not implemented batched private tokens, which are left out The API could be improved, but it is unclear yet as to how Fix lint Update arbitrary token implementation to use rfc 9000 varint The initial implementation was using an outdated version of the draft.
thibmeu
force-pushed
the
arbitrary-batched-tokens
branch
from
b3b7563 to
13e2c90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of arbitrary batched tokens. It passes the test vectors generated in Go.