feat(LayerCard): Add actions prop and LayerCard.Action component#406
Draft
mattrothenberg wants to merge 1 commit intomainfrom
Draft
feat(LayerCard): Add actions prop and LayerCard.Action component#406mattrothenberg wants to merge 1 commit intomainfrom
mattrothenberg wants to merge 1 commit intomainfrom
Conversation
commit: |
Contributor
Docs PreviewCommit: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.













































Summary
Adds first-class support for header actions in
LayerCard.Secondary:actionsprop - Slot for buttons, menus, and other action elementsLayerCard.Action- Pre-configured icon button that enforces consistent sizing (sm) and shape (square)renderprop - Escape hatch for custom elements like linksChanges
LayerCard.Secondarynow has consistentmin-h-10(40px) height whether actions are present or notjustify-betweenfor title/children on left, actions on rightUsage
Questions for reviewers
min-h-10(40px) the right height? It accommodatessmbuttons with some breathing roomsmbuttons another way, or is documentation +LayerCard.Actionsufficient?renderprop pattern for links?