Repository navigation
Triage issues by impact and cost, and fix them on request - #265
Conversation
|
commit: |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| 4. For a `priority: high` issue, send one message about it: a single lower-case line of plain text, | ||
| up to about 200 characters, saying whether it's valid, its impact and what happens next, without | ||
| restating the title. Use the issue's `updatedAt` as its expected version. |
There was a problem hiding this comment.
🔍 Check chat version after triage changes
message.send runs after labels and comments, which can change the issue's updatedAt. Check whether the original expected version causes high-priority messages to be skipped.
Was this helpful? React with 👍 or 👎 to provide feedback.
| trigger: | ||
| event: github.issue.labeled | ||
| labels-all: | ||
| - gardener-fix |
There was a problem hiding this comment.
🟥 Issue labels can trigger privileged code execution
If a non-maintainer can apply gardener-fix, github.issue.labeled starts repository.exec without checking the labeler's permissions. The task can then run commands and propose repository changes under the workflow token.
Was this helpful? React with 👍 or 👎 to provide feedback.
…ntributor guidance
Replaces the
triagetask with one that triages every new issue by weighing its impact against the cost of fixing it, and adds afixtask that implements a fix when a maintainer asks for one. Also upgrades Gardener to 0.1.18.Rollout: for now
triageruns automatically only on issues opened by @scuffi, and on manual runs (Actions → Gardener · Triage → Run workflow, with an issue number). That lets us check it on real issues while agent-think keeps triaging everything else. The cutover is a one-line follow-up that setsauthors: any, done at the same time as agent-think stops triaging.fixis live as soon as this merges, because it only runs when someone addsgardener-fix.triage, once cut over, runs on every new issue, from anyone:priority: high, plus a comment with the proposed fix. A maintainer can addgardener-fixto have it implemented.priority: high, plus a comment with the decision a maintainer needs to make.priority: low, no comment.wontfix, a short explanation, and closed. Rare, and only when the case is clear.question, with a brief answer or a request for what's missing. Spam is ignored.bugorenhancement. Issues left open are assigned to the person with the most recent substantive commits to the affected files who still has write access. It never assigns bots or anyone on the task's do-not-assign list.priority: highissues are posted to the team's chat with a one-line reason, once theGARDENER_CHAT_WEBHOOKsecret is set. Until then the message is skipped and the run stays green.fixruns when someone addsgardener-fixto an issue:allow-prthat starts withFixes #N.Safeguards
triagecan't run commands. Onlyfix, which a person starts, can.Other changes: Gardener's workflows and
gardener:generatemove to 0.1.18.mention-reply,pr-review-fixanddependabot-mergeare unchanged apart from the version pin. The runtime is already on 0.1.18. The labelspriority: high,priority: lowandgardener-fixalready exist.Tested on a demo repository: every outcome above, a
fixpull request from a label, a planted "mention everyone" instruction (ignored), and a missing chat secret (skipped, run green).