Let a test command raise its watchdog idle threshold - #442
Open
Maximo-Guk wants to merge 1 commit into
Open
Conversation
`gadgets-with-timeout --idle 60` reaps `workshop-backend`'s unit suite under CI contention. Import dominates that suite's runtime and vitest's non-TTY reporter only prints on file completion, so a healthy run goes quiet for long stretches -- no hang, just no output. Widen the command the task builders take to `TestCommand`, so one command can raise its own idle threshold without bumping the default for the other ~25 suites (which would also bust every package's vp cache). `withTestTimeout` stays unary, since `vitestTaskWithExclusions` hands it to `Array.prototype.map`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
LGTM! |
Maximo-Guk
marked this pull request as ready for review
September 4, 2026 03:15
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Preview:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gadgets-with-timeout --idle 60has been observed reapingworkshop-backend's unit suite under CI contention. Import dominates that suite's runtime and vitest's non-TTY reporter only prints on file completionThis PR widens the command the task builders take to
TestCommand(string | { command, idleSeconds }), so one command can raise its own idle threshold.