Add Google Drive document and folder creation by ndisidore · Pull Request #301 · cloudflare/cloudflare-os

ndisidore · 2026-08-21T21:13:02Z

Add approval-gated creation of blank Google Docs, Google Sheets, and folders to account and shared-drive bindings.
Keep exact-file bindings and Drive-opened native Docs and Sheets read-only; request drive.file only for broad creation-capable grants.
Revalidate destination scope and current Drive capabilities at submission and apply time, persist durable action outcomes, retry provider creates idempotently, and move created items to trash on revert.
Update resource declarations, configurator copy, and Google Drive documentation for the new capability boundary.

github-actions · 2026-08-24T22:04:46Z

Preview: `pr301-feat-gk-googl-52b434ba`

https://pr301-feat-gk-googl-52b434ba-router.cloudflare-os-previews.workers.dev

Dashboard · deleted when this PR closes

Maximo-Guk · 2026-08-25T16:04:13Z

Some GPT findings:

1. High: Ambiguous create failures can leave rejected files or produce duplicates. A timed-out POST stores no file ID; reject skips marker recovery, while retry may create again before marker search observes the first file. packages/gatekeeper-google/src/drive-creation.ts:244-253, :311-314
2. High: A shared-drive parent can move out of scope between validation and creation. The item is then created outside the binding, and cleanup refuses to trash it because it is out of scope. packages/gatekeeper-google/src/drive-creation.ts:242-251, :334-337
3. Medium: applyDriveCreation() treats a previously rejected action as successful. Concurrent reject/approve requests can therefore mark an action approved even though no file exists. packages/gatekeeper-google/src/drive-creation.ts:228-231
4. Medium: Destination metadata is validated before observation authorization. Failed probes reveal MIME type, trash state, creation marker, and write capability without audit or observer exclusion. packages/gatekeeper-google/src/drive-session.ts:273-280
5. Medium: Trash cleanup is not idempotent. If the file is already trashed, including after a crash between the PATCH and outcome write, retries can fail permanently on canTrash. packages/gatekeeper-google/src/drive-creation.ts:334-343
6. Medium: Creation names are unbounded and approval fencing is quadratic for long backtick runs, allowing oversized approval records and Worker CPU exhaustion. packages/gatekeeper-google/src/drive-creation.ts:145-147, packages/gatekeeper-google/src/approval-format.ts:7-10

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 1 new potential issue.

1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

devin-ai-integration · 2026-09-01T17:13:25Z

+async function trashCreatedFile(runtime: DriveCreationRuntime, fileId: string): Promise<void> {
+  let file = await runtime.api.getFile(fileId);
+  if (file.id !== fileId || runtime.scope.kind === "file" ||
+      !isDriveFileInScope(runtime.scope, file)) {
+    throw new Error("The requested file is outside this Drive binding.");
+  }
+  if (file.trashed === true) return;
+  if (file.capabilities?.canTrash !== true) {
+    throw new Error("The created Google Drive item cannot currently be moved to trash");
+  }
+  await runtime.api.trashFile(fileId);


🟨 Revert trusts stale file identity

trashCreatedFile never verifies the stored creation marker. A stale or corrupted ID can trash an unrelated in-scope file.

Was this helpful? React with 👍 or 👎 to provide feedback.

ask-bonk · 2026-09-01T17:24:18Z

+  storage: DriveCreationStorage, creationId: number, documentId: string, snapshot: DocSnapshot,
+): string {
+  let edits = new DriveCreationStore(storage).docEdits(creationId);
+  let pending = edits.list().map(({ id, action }) => ({


High: This replays edits that the provider may already have committed. If batchUpdate() writes the content and named range but its response is lost, the action remains pending; the next read fetches the committed content and overlays the same append again (or invalidates a replacement whose old text is now gone). Filter pending edits against the document's gadgets-write-* markers, as the existing Google Doc path does.

ask-bonk · 2026-09-01T17:24:18Z

+  }
+  let hasLaterEdits = store.listDocEdits(action.driveCreationId)
+    .some(record => record.id > actionId);
+  store.finishDocEdit(actionId);


High: Rejection needs to reconcile the provider marker before deleting this action. After a successful write whose response was lost, the action is still pending and the user can discard it; this path then reports rejection even though the document mutation remains applied.

ask-bonk · 2026-09-01T17:24:18Z

+      }))
+      .filter(({ id, outcome }) => {
+        if (!Number.isFinite(id) || retainedCreationIds.has(id)) return false;
+        return "actionType" in outcome ||


Medium: This makes created Sheets and folders prunable after 100 newer terminal records, but their approvals advertise implementsRevert: true. Once pruned, revertDriveCreation() has lost the file ID and can never perform that advertised revert; getCreationResult() also turns a valid handle into an unknown action. Retain the creation identity for as long as the approved action can be reverted.

ask-bonk · 2026-09-01T17:24:18Z

+        `**Old:** ${previewMarkdown(oldMarkdown, 80)}\n\n` +
+        `**New:** ${previewMarkdown(newMarkdown, 80)}`,
+    );
+  }
+
+  async appendText(markdown: string): Promise<void> {
+    await this.#snapshot();
+    await this.#submitEdit(
+      { type: "appendText", markdown },
+      "Append to app-created Google Doc",
+      `Append content to the app-created document:\n\n${previewMarkdown(markdown, 100)}`,


Medium: These approval descriptions show only the first 80/100 characters and interpolate them as raw Markdown. An approver cannot see arbitrary content after the preview, and content can forge the surrounding labels/text, while the full payload is applied. ActionDescription requires a complete description; bound the mutation itself and render the complete values with formatApprovalField().

ask-bonk · 2026-09-01T17:24:18Z

+    }
+  }
+
+  store.finishDocEdit(actionId);


Medium: Completing the action removes only local state; the gadgets-write-* named range created above is never deleted. Every successful edit therefore permanently adds provider metadata and enlarges all later documents.get responses until document or response limits are reached. Persist a completion receipt, then clean up the exact marker like the existing Google Doc implementation.

ask-bonk · 2026-09-01T17:24:18Z

+  ): Promise<void> {
+    resolveDriveCreatedDocument(this.storage, this.creationId);
+    let store = new DriveCreationStore(this.storage);
+    let actionId = store.submitDocEdit({


Medium: There is no capacity or payload bound for created-Doc edits. The existing 100-action check counts only creation actions, so a blocked gadget can persist unlimited edit payloads, and every simulated read enumerates and replays the entire backlog. Add an edit/action limit (and a payload bound) before storing this record.

ask-bonk · 2026-09-01T17:24:28Z

Submitted 6 actionable inline findings.

github run

devin-ai-integration

Devin Review found 1 new potential issue.

2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)

devin-ai-integration · 2026-09-01T18:30:57Z

+      : await this.#creationCoordinator.reject(this.#creationRuntime(), actionId);
+    return restart ? { restart: true } : undefined;


🟡 Rejected creation strands queued edits

When rejection returns { restart: true }, the Workshop caller ignores it. Auto-approved edits behind that creation remain pending without another drain trigger.

Prompt for agents

Wire the Gatekeeper.rejectAction restart result into Workshop action processing. packages/gatekeeper-google/src/google.ts now returns restart when rejecting a creation or edit changes the simulated action chain, but packages/workshop-backend/src/overseer.ts AwaitedApiImpl.rejectAction currently discards the callback return and never restarts auto-approval draining. Consume the result and trigger the same gatekeeper-scoped drain used after submissions/rule changes, while preserving the rejection record update ordering. Add an integration test with a manually rejected creation followed by auto-eligible document edits.

Was this helpful? React with 👍 or 👎 to provide feedback.

ask-bonk · 2026-09-01T18:41:11Z

+  async applyAction(actionId: number): Promise<void> {
+    let store = new DriveCreationStore(this.ctx.storage.kv);
+    if (store.isDocEdit(actionId)) {
+      await this.#creationCoordinator.run(


High: Callbacks are serialized by action ID, so edits belonging to the same created Doc can still interleave. For example, while append A is applying, rejecting B can fetch the still-pre-A snapshot; after A commits, B resumes its rebuild from that stale snapshot and invalidates a later replace C that targets A. C then completes via the invalidated-action branch without applying its still-valid mutation. Serialize apply/reject/revert by driveCreationId (or with one binding-wide mutex), not by each action ID.

ask-bonk · 2026-09-01T18:41:11Z

+    writeId: action.writeId,
+    ...(action.invalidatedReason ? { invalidatedReason: action.invalidatedReason } : {}),
+    ...action.edit,
+    ...(action.edit.type === "appendText" ? { preserveSpacing: true as const } : {}),


Medium: preserveSpacing makes simulation concatenate the raw fragment, but materialization parses that fragment as standalone Markdown before inserting it into the current final paragraph. With existing content text, appending # Heading simulates text# Heading, while markdownToDocRequests() treats the fragment as a heading and applies heading style to the whole existing paragraph, so the approved document reads back differently. Normalize the append boundary identically for simulation and provider requests.

ask-bonk · 2026-09-01T18:41:18Z

Submitted 2 actionable inline findings.

github run

github-actions Bot added delivery Changes to CI or release delivery gatekeeper Changes to a gatekeeper integration labels Aug 21, 2026

ndisidore force-pushed the feat/gk-google-drive-creation branch from 2a8cf1a to 60a28b8 Compare August 21, 2026 22:46

github-actions Bot removed the delivery Changes to CI or release delivery label Aug 21, 2026

ndisidore force-pushed the feat/gk-google-drive-creation branch from 60a28b8 to fb3e029 Compare August 24, 2026 22:02

ndisidore marked this pull request as ready for review August 24, 2026 22:26

ndisidore force-pushed the feat/gk-google-drive-creation branch from fb3e029 to 682c677 Compare August 26, 2026 23:30

devin-ai-integration Bot reviewed Aug 26, 2026

View reviewed changes

ndisidore force-pushed the feat/gk-google-drive-creation branch from 682c677 to 8c7215d Compare August 27, 2026 16:39

ndisidore force-pushed the feat/gk-google-drive-creation branch from 8c7215d to ebbbc84 Compare September 1, 2026 17:09

devin-ai-integration Bot reviewed Sep 1, 2026

View reviewed changes

ask-bonk Bot reviewed Sep 1, 2026

View reviewed changes

Base automatically changed from feat/gk-google-drive-native-sessions to main September 1, 2026 18:22

ndisidore added 3 commits September 1, 2026 13:22

Add Google Drive creation API

a5aa15b

Add Drive creation transport and scope checks

c16db2e

Add and harden Google Drive creation lifecycle

a1eecae

Add writable Google Drive creation workflow

6d7794c

ndisidore force-pushed the feat/gk-google-drive-creation branch from ebbbc84 to 6d7794c Compare September 1, 2026 18:22

devin-ai-integration Bot reviewed Sep 1, 2026

View reviewed changes

ask-bonk Bot reviewed Sep 1, 2026

View reviewed changes

		: await this.#creationCoordinator.reject(this.#creationRuntime(), actionId);
		return restart ? { restart: true } : undefined;

Uh oh!

Conversation

ndisidore commented Aug 21, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 24, 2026

Preview: pr301-feat-gk-googl-52b434ba

Uh oh!

Maximo-Guk commented Aug 25, 2026

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot commented Sep 1, 2026

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot commented Sep 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ndisidore commented Aug 21, 2026 •

edited by devin-ai-integration Bot

Loading

Preview: `pr301-feat-gk-googl-52b434ba`

devin-ai-integration Bot left a comment •

edited

Loading

devin-ai-integration Bot left a comment •

edited

Loading