[Email Routing] Document the addresses Wrangler configuration field - #31772
[Email Routing] Document the addresses Wrangler configuration field#31772DiogoSantoss wants to merge 3 commits into
Conversation
Review
👉 Fix in your agent 👈Fix the following review findings in PR #31772 (https://github.com/cloudflare/cloudflare-docs/pull/31772).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Suggestions (1)
#### CR-f1f177daae31 · Missing version requirement
- **File:** `src/content/docs/workers/wrangler/configuration.mdx` line 137
- **Issue:** The added `addresses` entry omits the Wrangler version requirement that the linked page documents: "This feature requires Wrangler 4.113.0 or later." (src/content/docs/email-service/configuration/email-routing-addresses.mdx). Users on older Wrangler versions will not have this field recognized.
- **Fix:** Consider adding a note that the `addresses` field requires Wrangler 4.113.0 or later, matching the email-routing-addresses page.
---
## Conventions
### Warnings (1)
#### CV-fd71c9729755 · Scope accuracy
- **File:** PR-level finding
- **Issue:** The PR adds a new changelog entry (src/content/changelog/email-service/2026-09-05-email-routing-wrangler-addresses.mdx, +24 lines) and its checklist item is checked as done, yet the description states "No changelog entry yet — that should accompany the feature launch" and marks the changelog item as deferred.
- **Fix:** Mention the new changelog entry in the description (and reconcile the checklist/notes), or remove it from the PR if it was added unintentionally.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (1)
ConventionsWarnings (1)
Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
a52fc87 to
9c321da
Compare
|
Thank you for reaching out. This issue appears to be spam or doesn't contain actionable documentation feedback, so we're closing it. If you have a genuine documentation question or suggestion, please open a new issue with details. |
dd9637c to
a2f15d7
Compare
|
Hey there, we've marked this pull request as stale because there's no recent activity on it. This label helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant). |
a2f15d7 to
1b826d0
Compare
|
/bonk review |
|
@irvinebroque Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
1b826d0 to
522ab33
Compare
|
I think the With Wrangler 4.129.0, I have an Email Routing subdomain This works: But this fails: with: The Dashboard appears to behave consistently with this: If this is an intentional platform limitation (one catch-all per zone/apex If subdomain catch-all is intended to work, then this may instead be a |
Summary
Documents the top-level
addressesWrangler configuration field, which lets you define Email Routing rules in yourwrangler.jsoncand have Worker trigger deployments reconcile those rules.Four changes:
workers/wrangler/configuration.mdx): addsaddressesunder Top-level only keys and clarifies that catch-all entries support apex domains only.email-service/configuration/email-routing-addresses.mdx): adds a Configure rules with Wrangler section with an example, the literal and catch-all behavior, the Wrangler version requirement, the deploy reconcile/plan flow, and--dry-run.email-service/configuration/subdomains.mdx): clarifies that subdomains support literal routing rules but not catch-all rules.Notes for reviewers
/rulesREST API reference is auto-generated fromcloudflare/api-schemas(fetched insrc/util/api.ts), so the endpoint reference is not editable here — the schema changes (newsourcefield,/rules/plan, error codes) are handled on the API-schema side. This PR only touches hand-written prose.Documentation checklist