Skip to content

[Email Routing] Document the addresses Wrangler configuration field - #31772

Open
DiogoSantoss wants to merge 3 commits into
cloudflare:productionfrom
DiogoSantoss:dsantos/EMAIL-1883
Open

[Email Routing] Document the addresses Wrangler configuration field#31772
DiogoSantoss wants to merge 3 commits into
cloudflare:productionfrom
DiogoSantoss:dsantos/EMAIL-1883

Conversation

@DiogoSantoss

@DiogoSantoss DiogoSantoss commented Jun 29, 2026

Copy link
Copy Markdown

Summary

Documents the top-level addresses Wrangler configuration field, which lets you define Email Routing rules in your wrangler.jsonc and have Worker trigger deployments reconcile those rules.

Four changes:

  • Wrangler configuration reference (workers/wrangler/configuration.mdx): adds addresses under Top-level only keys and clarifies that catch-all entries support apex domains only.
  • Email Routing rules how-to (email-service/configuration/email-routing-addresses.mdx): adds a Configure rules with Wrangler section with an example, the literal and catch-all behavior, the Wrangler version requirement, the deploy reconcile/plan flow, and --dry-run.
  • Email Routing subdomains how-to (email-service/configuration/subdomains.mdx): clarifies that subdomains support literal routing rules but not catch-all rules.
  • Email Service changelog: announces the new Wrangler-managed Email Routing configuration.

Notes for reviewers

  • The /rules REST API reference is auto-generated from cloudflare/api-schemas (fetched in src/util/api.ts), so the endpoint reference is not editable here — the schema changes (new source field, /rules/plan, error codes) are handled on the API-schema side. This PR only touches hand-written prose.
  • The local full build and link check pass.

Documentation checklist

  • Is there a changelog entry?
  • The change adheres to the documentation style guide.

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning, 💡 1 suggestion found in commit 5a54027.

👉 Fix in your agent 👈
Fix the following review findings in PR #31772 (https://github.com/cloudflare/cloudflare-docs/pull/31772).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Suggestions (1)

#### CR-f1f177daae31 · Missing version requirement
- **File:** `src/content/docs/workers/wrangler/configuration.mdx` line 137
- **Issue:** The added `addresses` entry omits the Wrangler version requirement that the linked page documents: "This feature requires Wrangler 4.113.0 or later." (src/content/docs/email-service/configuration/email-routing-addresses.mdx). Users on older Wrangler versions will not have this field recognized.
- **Fix:** Consider adding a note that the `addresses` field requires Wrangler 4.113.0 or later, matching the email-routing-addresses page.

---

## Conventions

### Warnings (1)

#### CV-fd71c9729755 · Scope accuracy
- **File:** PR-level finding
- **Issue:** The PR adds a new changelog entry (src/content/changelog/email-service/2026-09-05-email-routing-wrangler-addresses.mdx, +24 lines) and its checklist item is checked as done, yet the description states "No changelog entry yet — that should accompany the feature launch" and marks the changelog item as deferred.
- **Fix:** Mention the new changelog entry in the description (and reconcile the checklist/notes), or remove it from the PR if it was added unintentionally.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Suggestions (1)
File Issue
workers/wrangler/configuration.mdx line 137 Missing version requirement — The added addresses entry omits the Wrangler version requirement that the linked page documents: "This feature requires Wrangler 4.113.0 or later." (src/content/docs/email-service/configuration/email-routing-addresses.mdx). Users on older Wrangler versions will not have this field recognized. Fix: Consider adding a note that the addresses field requires Wrangler 4.113.0 or later, matching the email-routing-addresses page.

Conventions

Warnings (1)
File Issue
PR Scope accuracy — The PR adds a new changelog entry (src/content/changelog/email-service/2026-09-05-email-routing-wrangler-addresses.mdx, +24 lines) and its checklist item is checked as done, yet the description states "No changelog entry yet — that should accompany the feature launch" and marks the changelog item as deferred. Fix: Mention the new changelog entry in the description (and reconcile the checklist/notes), or remove it from the PR if it was added unintentionally.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@DiogoSantoss
DiogoSantoss force-pushed the dsantos/EMAIL-1883 branch 2 times, most recently from a52fc87 to 9c321da Compare June 30, 2026 13:06
@DiogoSantoss
DiogoSantoss marked this pull request as draft June 30, 2026 13:06
@cloudflare-docs-bot

Copy link
Copy Markdown
Contributor

Thank you for reaching out. This issue appears to be spam or doesn't contain actionable documentation feedback, so we're closing it. If you have a genuine documentation question or suggestion, please open a new issue with details.

@NuroDev NuroDev reopened this Jul 2, 2026
@DiogoSantoss
DiogoSantoss marked this pull request as ready for review July 15, 2026 12:36
@DiogoSantoss
DiogoSantoss force-pushed the dsantos/EMAIL-1883 branch 3 times, most recently from dd9637c to a2f15d7 Compare July 20, 2026 13:13
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Hey there, we've marked this pull request as stale because there's no recent activity on it. This label helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant).

@github-actions github-actions Bot added the stale label Aug 4, 2026
@mvvmm mvvmm removed the spam label Aug 7, 2026
@irvinebroque

Copy link
Copy Markdown
Contributor

/bonk review

@ask-bonk

ask-bonk Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

github run

@ask-bonk

ask-bonk Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@irvinebroque Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@catwithlover

Copy link
Copy Markdown

I think the *@domain documentation may need to clarify how
catch-all addresses interact with Email Routing subdomains.

With Wrangler 4.129.0, I have an Email Routing subdomain
agent.asyncat.app successfully onboarded.

This works:

"addresses": ["ai@agent.asyncat.app"]

But this fails:

"addresses": ["*@agent.asyncat.app"]

with:

Unknown Email Routing domain:
No Email Routing domain found for *@agent.asyncat.app
[code: 2062]

The Dashboard appears to behave consistently with this:
when creating a literal Email trigger, agent.asyncat.app can be selected,
but after enabling "Match every address on the domain", only apex domains
are available in the Domain selector.

If this is an intentional platform limitation (one catch-all per zone/apex
domain rather than per onboarded Email Routing domain), I think it should be
documented here, since both the Wrangler schema and the current wording
*@domain appear to imply that an onboarded subdomain is valid.

If subdomain catch-all is intended to work, then this may instead be a
platform/Wrangler bug.

@irvinebroque
irvinebroque requested a review from a team as a code owner September 5, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants