[Workers] Add existing project deployment guide for React + Vite - #31275
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Review⏸️ Automatic reviews for this PR are paused. This PR has already received 2 automatic reviews. To run another review, a codeowner can comment
❌ Review failed for commit |
|
This first PR is focused on extracting the Vite Plugin tutorial into partials that can be reused in the Framework Guides 'deploy your project' sections |
There was a problem hiding this comment.
6 issues found. 3 inline suggestions posted for the partials; 3 additional issues noted below.
HIGH
src/content/docs/workers/framework-guides/web-apps/react.mdxline 7: Thedescriptionfrontmatter is outdated. It only mentions creating a new project, but the page now covers deploying existing projects too. Update it to reflect both paths.src/content/docs/workers/framework-guides/web-apps/react.mdxlines 13–15:Badge,Description, andInlineBadgeare imported but never used. Remove them from the import block.
MEDIUM
src/content/docs/workers/vite-plugin/tutorial.mdxline 8: Therevieweddate is stale (2025-04-04) after this significant refactor. Consider updating it if the content was verified end-to-end.
Out of scope
src/content/docs/workers/framework-guides/web-apps/react.mdxline 208:./worker/index.tsshould be in backticks per the style guide, but this is a pre-existing issue.
|
Labels applied: Posted a review with 3 inline suggestions and a summary comment covering 6 issues. HIGH
MEDIUM
Out of scope
PR otherwise looks structurally sound: no unescaped MDX characters, links are root-relative with trailing slashes, |
97fbd75 to
5cbf41b
Compare
|
/bonk rereview |
There was a problem hiding this comment.
All issues from the first review have been resolved. One new style guide issue found.
MEDIUM
src/content/partials/workers/vite-plugin/add-api-worker.mdxline 11: Worker code must useTypeScriptExample, not a baretsfence. Update the import on line 5 to includeTypeScriptExampleand wrap the code block in<TypeScriptExample filename="worker/index.ts">.
|
All issues from the first review have been resolved:
One new issue found and posted to PR #31275: MEDIUM
|
|
Hey there, we've marked this pull request as stale because there's no recent activity on it. This label helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant). |
|
/bonk resolve merge conflicts and update pr |
|
To https://github.com/cloudflare/cloudflare-docs.git |
|
@irvinebroque Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
|
Hey there, we've marked this pull request as stale because there's no recent activity on it. This label helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant). |
5cbf41b to
f45b853
Compare
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://react-vite-existing-project-guide.previews.developers.cloudflare.com (commit c9360e5)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
…ide violations, and use toml in WranglerConfig
f45b853 to
147b9ea
Compare
Summary
Updates the React + Vite framework guide to include instructions for deploying an existing React + Vite project to Cloudflare Workers, not just creating a new one from scratch.
The guide now uses tabs to separate the two paths:
Reusable steps from the Vite plugin tutorial have been extracted into shared partials under
src/content/partials/workers/vite-plugin/. Both the tutorial and the React framework guide now consume these partials, eliminating duplication and making the content easier to reuse for other framework guides in the future.Partial files created:
add-dependencies.mdxadd-plugin-to-vite-config.mdxcreate-wrangler-config.mdxupdate-gitignore.mdxrun-dev-server.mdxbuild-app.mdxpreview-app.mdxdeploy.mdxadd-tsconfig-worker.mdxadd-worker-config.mdxadd-api-worker.mdxScreenshots (optional)
Documentation checklist