Draft
Conversation
- Remove duplicate upload_issuers implementations. - Make ObjectBackend methods parameters more flexible for convenience. - Rename ProofPreparer -> TlogTileRecorder as this is now used for more than just proofs. (We probably want to move this and PreloadedTlogTileReader to tlog_tiles, but leaving that out of this PR to reduce the diff.) - Rename SimpleTlogTileReader -> PreloadedTlogTileReader as more descriptive name - Rename RecordProof -> InclusionProof for consistency with RFC9162 terminology - Rename TreeProof -> ConsistencyProof for consistency with RFC9162 terminology - Add `tile_reader_for_indexes` function to deduplicate logic across prove_inclusion, prove_consistency, and read_edge_tiles. - Use TileHashReader::read_hashes to fetch edge tiles, removing the need for the `read_and_verify_tiles` function and aligning the code more closely to sunlight: https://github.com/FiloSottile/sunlight/blob/409a4d4913368c7e28d012118e567eb1f8c90900/internal/ctlog/ctlog.go#L243. - Move ProveInclusionQuery/Response structs to mtc frontend worker. Now that prove-inclusion requests are handled without contacting the sequencer, these application-specific endpoints should be defined with the application.
As a measure to prevent #84, immediately confirm that we can fetch the correct objects from R2 after they are uploaded. I was having trouble getting the sentry integration working, so in the meantime update the Cleaner to just check that each full level-0 tile exists. This will stop progress indefinitely to allow us to detect if more tiles go missing.
bwesterb
approved these changes
Aug 3, 2025
lukevalenta
force-pushed
the
lvalenta/r2-check
branch
from
fc11690 to
48f511e
Compare
Contributor
Author
|
I think at this point the only useful commit from this PR is b2141bc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll probably leave this PR as a draft until the next stable release of the RustCrypto libraries.