Rename mtc_worker and mtc_api to bootstrap_mtc_worker and bootstrap_mtc_api, closes #196#199
Open
lukevalenta wants to merge 1 commit intolvalenta/remove-psc-187from
Open
Conversation
…tc_api, closes #196 Renames both crates and all associated types to distinguish the bootstrap MTC implementation (used for the bootstrap MTC experiment) from the forthcoming 'real' MTC implementation (#197). We'll move shared functionality into a common crate later. Crate renames: - crates/mtc_worker/ → crates/bootstrap_mtc_worker/ - crates/mtc_api/ → crates/bootstrap_mtc_api/ Type and symbol renames in integration_tests: - MtcClient → BootstrapMtcClient - MtcChain → BootstrapMtcChain - make_mtc_chain → make_bootstrap_mtc_chain - mtc_log_name → bootstrap_mtc_log_name - MTC_LOG_NAME → BOOTSTRAP_MTC_LOG_NAME - AddEntryResponse → BootstrapMtcAddEntryResponse - GetCertificateResponse → BootstrapMtcGetCertificateResponse - MtcMetadataResponse → BootstrapMtcMetadataResponse - tests/mtc_api.rs → tests/bootstrap_mtc_api.rs
lukevalenta
requested review from
a team,
bwesterb,
cjpatton,
mendess and
rozbb
as code owners
Contributor
Author
|
/bonk review |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good — the rename is clean and complete.
I verified:
- No stale references: Every occurrence of the old names (
mtc_worker,mtc_api,MtcClient,MtcChain,make_mtc_chain,mtc_log_name,MTC_LOG_NAME,MtcMetadataResponse,tests/mtc_api.rs) has been renamed. No stragglers in Cargo manifests, Rust source, CI workflows, or docs. - Old directories removed:
crates/mtc_worker/andcrates/mtc_api/no longer exist. - All 37 changed files are consistent: Root
Cargo.toml,Cargo.lock, all sub-crateCargo.tomls,build.rs,usestatements, integration tests,.github/workflows/integration.yml, andAGENTS.mdall reference the newbootstrap_mtc_*names. - Crate-internal types like
AddEntryResponseandGetCertificateResponsecorrectly keep their short names since they're already namespaced by the renamed crate — no issue there. wrangler.jsoncstill has"name": "mtc"and R2 bucket namesmtc-public-dev*— these are provisioned infrastructure identifiers, not code references, so leaving them as-is is correct.
No issues found.
|
PR #199 has been approved. The rename from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this is based on #198, so merge that first.
Renames both crates and all associated types to distinguish the bootstrap MTC implementation (used for the bootstrap MTC experiment) from the forthcoming 'real' MTC implementation (#197). We'll move shared functionality into a common crate later.
Crate renames:
Type and symbol renames in integration_tests: