Skip to content

⚡ Bolt: [performance improvement] Avoid deep clones during OpenAPI parsing - #102

Draft
cloudesize67-cmd wants to merge 1 commit into
mainfrom
bolt-serde-clone-opt-1133430135790827741
Draft

⚡ Bolt: [performance improvement] Avoid deep clones during OpenAPI parsing#102
cloudesize67-cmd wants to merge 1 commit into
mainfrom
bolt-serde-clone-opt-1133430135790827741

Conversation

@cloudesize67-cmd

Copy link
Copy Markdown
Owner

💡 What: Replaced serde_yaml::from_value::<Type>(value.clone()) and serde_json::from_value::<Type>(value.clone()) with Type::deserialize(value) across the OpenAPI parsing logic.
🎯 Why: Calling .clone() on an intermediate AST (Value) deeply clones all nodes (strings, maps, arrays) before deserialization, heavily increasing memory allocations for large OpenAPI specs. By using the Deserializer trait implemented on &Value, Serde only extracts and copies the fields specifically required by the target struct.
📊 Impact: Considerably reduces memory allocations and heap usage during OpenAPI schema parsing, improving load time and throughput.
🔬 Measurement: Verify by parsing a large OpenAPI specification using xdk-openapi and observing the reduction in memory allocations (e.g. using a memory profiler like valgrind or standard Rust benchmarking tools). Or simply checking time taken to parse large files.


PR created automatically by Jules for task 1133430135790827741 started by @cloudesize67-cmd

Co-authored-by: cloudesize67-cmd <237356855+cloudesize67-cmd@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant