Skip to content

⚡ Bolt: [performance improvement] avoid deep cloning Serde Value ASTs - #101

Draft
cloudesize67-cmd wants to merge 1 commit into
mainfrom
bolt/optimize-serde-deserialize-ast-9634661704593602609
Draft

⚡ Bolt: [performance improvement] avoid deep cloning Serde Value ASTs#101
cloudesize67-cmd wants to merge 1 commit into
mainfrom
bolt/optimize-serde-deserialize-ast-9634661704593602609

Conversation

@cloudesize67-cmd

Copy link
Copy Markdown
Owner

💡 What:

Replaced calls to serde_yaml::from_value(val.clone()) and serde_json::from_value(val.clone()) with T::deserialize(val) in xdk-openapi/src/parser.rs. Brought serde::Deserialize into scope.

🎯 Why:

The original code performed a deep clone of the entire serde_json::Value or serde_yaml::Value AST subtree just to deserialize it into components (schemas, parameters, responses, etc.). This allocated unnecessary memory and traversed the tree redundantly. Because &Value implements the Deserializer trait, we can deserialize directly from the reference.

📊 Impact:

Eliminates deep tree cloning of the JSON/YAML AST for every OpenAPI component parsed. This reduces memory allocation and CPU cycles during the parsing phase, resulting in faster SDK generation times, especially for massive OpenAPI specifications.

🔬 Measurement:

Run make check and make test-generator to ensure all functionality is correctly preserved without regressions. The performance improvement can be measured by profiling the memory allocations during the parser phase with large OpenAPI specs.


PR created automatically by Jules for task 9634661704593602609 started by @cloudesize67-cmd

Optimizes OpenAPI parsing by replacing `serde_json::from_value(val.clone())` and `serde_yaml::from_value(val.clone())` with direct `T::deserialize(val)` calls. This leverages the fact that `&Value` implements `Deserializer`, bypassing expensive deep copies of AST subtrees entirely.

Co-authored-by: cloudesize67-cmd <237356855+cloudesize67-cmd@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant