gh-209: implement mgclass by zsirap · Pull Request #302 · cloe-org/cloelib

zsirap · 2025-10-23T01:11:38Z

🚀 Pull Request Checklist

✅ Summary

closes #290

🔄 Changes

allows the user to call additional parameters for the different models in MGCLASS
allows to import separate CLASS and MGCLASS in the same python script

🛠 How to Test

📝 Documentation

This PR updates documentation

🏗 Related Issues

Resolves #290

📸 Screenshots (if applicable)

📌 Additional Notes

✅ PR Checklist for Developers

I have titled this PR before merging as "gh-#:", where "#" represents the task it closes
I have run locally pre-commit using pre-commit run --all-files
I have tested my changes locally
No new warnings or errors introduced
I have updated documentation (if applicable)
My changes do not introduce breaking changes (i.e: the package still gets installed)
I have added unit tests (if applicable)
I have consistently updated the GitHub information for the project, including milestones, task types, and other relevant details.

✅ PR Checklist for Reviewers

zsirap · 2025-10-23T01:19:00Z

I am still getting style errors that I don't know the origin (though locally the style test and mglass test pass) if you can help on that @gcanasherrera

update: i see other PRs have some similar issues ... later i might recheck again to see if i manage to solve mine .. for time being i labeled the PR as draft but it can be already reviewed at your or any other reviewer ease

gcanasherrera · 2025-10-23T11:13:18Z

Make sure this title of this PR is properly named

zsirap · 2025-10-29T02:27:20Z

not a draft anymore ... it only fails now because MGCLASS is an external code and is not automatically installed ... otherwise it passes locally ...

gcanasherrera · 2025-10-29T10:16:13Z

Hi @zsirap,

Before I jump into the reviewing and into addressing the issue on how to install MGCLASS into the CI environment, could you please make sure that you are following properly the requests specified in the PR Checklist for Developers?

For instance, you have clicked as done "I have titled this PR before merging as "gh-#:", where "#" represents the task it closes", however you have not done it.

Also, make sure you have a proper picture that you would like to share in your GitHub profile so that the all-contributors bot gives you visibility accordantly (if you want to keep the default GitHub picture, too, it's also fine).

zsirap · 2025-10-29T10:53:33Z

For instance, you have clicked as done "I have titled this PR before merging as "gh-#:", where "#" represents the task it closes", however you have not done it.

ah i thought you meant by this previous comment changing the title to make it more suitable ...

Make sure this title of this PR is properly named

my bad .. ok done now i hope ...

Before I jump into the reviewing

no rush .. at your ease @gcanasherrera ..

if you want to keep the default GitHub picture, too, it's also fine

for the moment ... maybe later

gcanasherrera · 2025-10-29T20:49:47Z

Hi @zsirap,

Thanks for this. As you're one of the main users of MGCLASS, I was wondering: why don't you make it pip installable so it is easier for us to install, also in the CI?
CC- @matmartinelli

gcanasherrera

Please, adapt the names to MGCLASS instead of CLASS only everywhere

zsirap · 2026-05-04T05:24:24Z

The closest it can be ready within last or this week deadline ... however couldn't manage but to still need to install mgclass separately in ci.yaml .. solving that in the future requires to separate/rename internal functions completely from class, or fully align with latest version of class but we see the issues when any of the xxclass pip is built on a diff version than plain class ...

It remains to include Ivan's fix I guess after he merges his branch ... note that I was already aware of the bug but was changing in private the lkl in cloelike instead but now will follow his fix though don't know where the fix should be: in the BS, or the emulators or the cloelike but let's suppose that Ivan fix is the best option thus I will implement it ...

Note also that while investigating where the fix should be I spotted some issues in some of the protocols such that I might open an issue to address/discuss them ...

gcanasherrera · 2026-05-04T12:00:13Z

You're assigned to this one @santiagocasas, you're more than a CLASS person than me.

gcanasherrera · 2026-05-04T16:53:12Z

@zsirap (CC- @santiagocasas):

note how class is now interfacing in the main branch, where it requires an optional linear module to be passed to the non-linear module. This is to allow for cloelike interface. Please, follow the same approach in mgclass

santiagocasas · 2026-05-08T12:38:15Z

@gcanasherrera yes, I am taking a look into this. But regarding your comment on the linear module being passed, I think we should make mgclass and hi_class more modular. We are currently duplicating a lot of boilerplate code for background for instance, and this is not only dangerous but difficult to maintain (cloelib/cosmology/mgclass_cosmology.py).

Let me think about this for a day.

santiagocasas · 2026-05-08T12:38:33Z

thanks @zsirap for your work on this so far

santiagocasas

all in all, quite close to finishing, but a few things need revision. Especially Protocol adherence and the physical error (double-check!) in Omega_cb and so on. See below! thanks!

santiagocasas · 2026-05-12T14:39:08Z

        run: |
          mamba run -n $ENV_NAME python -m pip install --upgrade pip
          mamba run -n $ENV_NAME python -m pip install ".[camb,classy,euclidemu2,baccoemu]"
+      - name: Install external prereq using pip


please don't install mgclassy like that. Use the same format as for the other external codes and solve the conflict, so that all codes are there. There is no need to specify the version, this is installed via the pyproject.toml and this is set there already: mgclassy = ["mgclassy==2.9.4.5"]

santiagocasas · 2026-05-12T14:40:59Z

+        self.Omega_cdm0 = Omega_cdm0
+        self.Omega_k0 = Omega_k0
+        self.As = As
+        self.ns = ns


please rebase to latest version of main and add here the new requirement in the Background protocol, the parameter alpha_s. See here:

cloelib/cloelib/cosmology/class_cosmology.py

Line 39 in c33e526

alpha_s: float = 0.0,

santiagocasas · 2026-05-12T14:44:27Z

+                [
+                    (self.results.Omega_b() + self.results.Omega0_cdm())
+                    * (1 + z) ** 3.0
+                    / (self.hubble_parameter(z) / self.H0) ** 0.5


why the square root of E(z)? , it should be (E(z))^2.
If possible, simply use the exposed variables as CLASS does: return self.results.Om_b(zs) + self.results.Om_cdm(zs).
Also, avoid for-loops. These functions are usually broadcastable.

santiagocasas · 2026-05-12T14:50:57Z

+    return {"Linear": mgclass_lin, "NonLinear": mgclass_non}
+
+
+@pytest.mark.parametrize("key", ["Linear"])


change to @pytest.mark.parametrize("key", ["Linear", "NonLinear"]) so you also test the NonLinear adherence to the protocol

santiagocasas · 2026-05-12T14:54:41Z

+        )
+
+        return D_z_k
+


for MGCLASSNonLinearPerturbations to adhere to the Perturbations protocol, it needs to have a growth_rate, see here:

cloelib/cloelib/cosmology/class_cosmology.py

Line 578 in c33e526

def growth_rate(self) -> np.ndarray:

Tests were passing because you were not testing protocol adherence in NonLinear. See my comment in tests/test_mgclass_cosmology.py

santiagocasas · 2026-05-12T14:58:26Z

+
+    # add neutrinos:
+    mgclass_background_instance.interface_args["MGCLASSparams"]["N_ncdm"] = 1
+    mgclass_background_instance.interface_args["MGCLASSparams"]["m_ncdm"] = 0.2


using this here, while leaving these other parameters as:
mgclass_background_instance.mnu == 0.0 mgclass_background_instance.N_mnu == 0
is inconsistent, in case someone uses another parametrization. Tests might fail or pass for the wrong reason

gcanasherrera · 2026-05-19T07:38:32Z

@zsirap do you have any time scale for addressing these comments?

zsirap · 2026-05-19T08:00:26Z

@zsirap do you have any time scale for addressing these comments?

was in a workshop ... will start addressing them from today ... thanks for reminding me and thanks to @santiagocasas for the extra review

…call non linear, Ez bug etc ...

zsirap and others added 10 commits October 13, 2025 14:30

allowing_MG_cosmology_using_MGCLASS

678d2fc

update mgclass_cosmology to comply with new class_cosmology

c91f538

style fix mgclass_cosmology.py

afc4ca1

style fix mgclass_cosmology.py

8e7e0c7

style fix mgclass_cosmology.py

728412a

style fix mgclass_cosmology

a34ae4f

format mgclass_cosmology

35a9f1a

Merge remote-tracking branch 'origin/main' into 290_mgclass_BZ

6a63194

Update pyproject.toml to add mgclass

210fe8d

Update README.md to add mgclass info

3727285

zsirap requested a review from gcanasherrera October 23, 2025 01:11

gcanasherrera assigned zsirap Oct 23, 2025

gcanasherrera added background-perturbations Tasks related to Background and Perturbations th-1 labels Oct 23, 2025

gcanasherrera added this to the v0.11 milestone Oct 23, 2025

zsirap changed the title ~~290 mgclass bz~~ 290 mgclass integration Oct 23, 2025

zsirap marked this pull request as ready for review October 29, 2025 02:24

zsirap changed the title ~~290 mgclass integration~~ 290 implement mgclass Oct 29, 2025

zsirap changed the title ~~290 implement mgclass~~ gh-implement mgclass Oct 29, 2025

zsirap changed the title ~~gh-implement mgclass~~ gh-209: implement mgclass Oct 29, 2025

gcanasherrera requested changes Oct 29, 2025

View reviewed changes

ziwangithub and others added 3 commits October 30, 2025 03:52

style fix

811b3a6

fix style test_mgclass_cosmology.py

a1d78ff

Merge remote-tracking branch 'origin/main' into 290_mgclass_BZ

4d844b6

ziwangithub added 6 commits April 16, 2026 22:41

mgclass style fix

86d7f18

mgclass Omega(s) call fix

bc2511d

mgclass style fix

c4a2c00

mgclass Omega(s) call fix

9869b60

mgclass style fix

252e652

mgclass style fix

c437b0a

gcanasherrera marked this pull request as draft April 16, 2026 22:01

ziwangithub added 10 commits April 17, 2026 05:50

mgclass style fix

4eec96f

mgclass style fix

22009e9

Merge remote-tracking branch 'origin/main' into 290_mgclass_BZ

de40a56

Merge remote-tracking branch 'origin/main' into 290_mgclass_BZ

7121f3f

fix intallation of mgclassy

1733b02

fix intallation of mgclassy

e3f7372

fix intallation of mgclassy

d2a0902

fix intallation of mgclassy

706be33

Merge remote-tracking branch 'origin/main' into 290_mgclass_BZ

8165e86

update cloelib docs folder with mgclass info

cdd4a9e

gcanasherrera marked this pull request as ready for review May 4, 2026 11:59

gcanasherrera requested a review from santiagocasas May 4, 2026 11:59

gcanasherrera added the priority For PM purposes label May 11, 2026

santiagocasas requested changes May 12, 2026

View reviewed changes

zsirap added 2 commits May 25, 2026 13:21

fix conflicts with main

45b7ca4

update with main + solve review issues: add alpha_s, a fix to how we …

617b22b

…call non linear, Ez bug etc ...

		return {"Linear": mgclass_lin, "NonLinear": mgclass_non}


		@pytest.mark.parametrize("key", ["Linear"])

Conversation

zsirap commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Pull Request Checklist

✅ Summary

🔄 Changes

🛠 How to Test

📝 Documentation

🏗 Related Issues

📸 Screenshots (if applicable)

📌 Additional Notes

✅ PR Checklist for Developers

✅ PR Checklist for Reviewers

Uh oh!

zsirap commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gcanasherrera commented Oct 23, 2025

Uh oh!

zsirap commented Oct 29, 2025

Uh oh!

gcanasherrera commented Oct 29, 2025

Uh oh!

zsirap commented Oct 29, 2025

Uh oh!

gcanasherrera commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gcanasherrera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zsirap commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gcanasherrera commented May 4, 2026

Uh oh!

gcanasherrera commented May 4, 2026

Uh oh!

santiagocasas commented May 8, 2026

Uh oh!

santiagocasas commented May 8, 2026

Uh oh!

santiagocasas left a comment

Choose a reason for hiding this comment

Uh oh!

santiagocasas May 12, 2026

Choose a reason for hiding this comment

Uh oh!

santiagocasas May 12, 2026

Choose a reason for hiding this comment

Uh oh!

santiagocasas May 12, 2026

Choose a reason for hiding this comment

Uh oh!

santiagocasas May 12, 2026

Choose a reason for hiding this comment

Uh oh!

santiagocasas May 12, 2026

Choose a reason for hiding this comment

Uh oh!

santiagocasas May 12, 2026

Choose a reason for hiding this comment

Uh oh!

gcanasherrera commented May 19, 2026

Uh oh!

zsirap commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

zsirap commented Oct 23, 2025 •

edited

Loading

zsirap commented Oct 23, 2025 •

edited

Loading

gcanasherrera commented Oct 29, 2025 •

edited

Loading

zsirap commented May 4, 2026 •

edited

Loading