Closed
Conversation
Collaborator
|
I think we want to prioritize #4777 over this patch. Ultimately it should have the same effect which is to avoid crashing the server, but it will also terminate the request instead of increasing the heap limit unconditionally. |
Collaborator
Author
|
Ok sounds good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Note: the changes here were 100% generated by claude code but the PR description was written by me.
This fixes the issue by registering a callback for when the V8 runtime is almost out of heap space.
API and ABI breaking changes
None
Expected complexity level and risk
1 - This just registers a callback for the V8 runtime
Testing