Merged
Conversation
drogus
force-pushed
the
drogus/fix-subscriptions-bug
branch
from
f9868c0 to
a0af376
Compare
drogus
changed the title
drogus
force-pushed
the
drogus/fix-subscriptions-bug
branch
from
a0af376 to
b26e3f2
Compare
drogus
force-pushed
the
drogus/fix-subscriptions-bug
branch
from
01184c6 to
0c7d7c9
Compare
drogus
force-pushed
the
drogus/fix-subscriptions-bug
branch
from
0c7d7c9 to
7b7ccec
Compare
Contributor
Author
|
@joshua-spacetime I update the PR, so that the test is actually testing what I wanted to test |
joshua-spacetime
approved these changes
Apr 22, 2024
bfops
added
release-any
cloutiertyler
added
release-0.10
and removed
release-any
|
|
jdetter
force-pushed
the
drogus/fix-subscriptions-bug
branch
from
0990ddd to
d2f837e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
While working on #1111 I realised that we have a bug with subscriptions not being unique when multiple clients with the same identity are connected. I fixed the bug and only then realised it was already fixed yesterday in #1121. When working on my changes I created a test for the issue, so I guess it doesn't hurt to at least submit it.
Expected complexity level and risk
1