Add currency field to Notation class - #8
Open
ralf1070 wants to merge 7 commits into
Open
Conversation
…nalysis Major enhancements: - Added comprehensive fundamental analysis capabilities - Integrated ESG (Environmental, Social, Governance) data - Implemented advanced financial ratios calculations - Added async/await support with aiohttp for better performance - Enhanced error handling and retry mechanisms - Added extensive test coverage with new test suites - Created comprehensive documentation and examples - Maintained full backward compatibility with v1.x - Published as pyonvista-v2 on PyPI to avoid naming conflicts New features: - Financial ratios: P/E, P/B, ROE, ROA, Debt-to-Equity, etc. - ESG scores and sustainability metrics - Enhanced company fundamentals data - Improved caching and rate limiting - Better data validation and error reporting - Comprehensive logging support Technical improvements: - Async HTTP client with aiohttp - Improved code structure and modularity - Enhanced testing with pytest-asyncio - Better configuration management - Improved package metadata and PyPI integration
- Updated installation instructions to use 'pyonvista-v2' package name - Added PyPI package section with direct link to https://pypi.org/project/pyonvista-v2/ - Clarified package naming to avoid confusion with original pyonvista - All import statements remain unchanged for backward compatibility
Port currency support from local v1 modifications. Extracts isoCurrency from API response to distinguish notations by currency (e.g., SWX with CHF vs USD).
Reviewed and tested. Clean, backward-compatible enhancement that adds currency field to Notation class for distinguishing notations by currency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract isoCurrency from API response and store it in the Notation dataclass for each market notation.