Allow the IRC channel, nick, and URL to be specified in environment variables#22
Open
banksJeremy wants to merge 1 commit intocliss:masterfrom
Open
Allow the IRC channel, nick, and URL to be specified in environment variables#22banksJeremy wants to merge 1 commit intocliss:masterfrom
banksJeremy wants to merge 1 commit intocliss:masterfrom
Conversation
Contributor
|
👍 |
Contributor
Author
|
This could help prevent another occurence of accidentally leaving a chanel modification in the a PR, as just happened at #26 (comment) 😉 (at least from users developing somewhere they can conveniently set different environment variables). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With all of these test bots around, we could make it easier to get them out of #atp and uniquely identify themselves.