Repository navigation
fix(deps): bump brace-expansion to 1.1.21 and 5.0.12 - #3
Merged
Merged
Conversation
Closes Dependabot alerts #27 and #28 (quadratic-time `{a},b}` expansion,
CPU denial of service). Both copies are dev-only, reached through
eslint's and typescript-estree's minimatch, and both bumps are in range
for their parents, so only the lockfile changes. Receipts for the three
scenarios that pin package-lock.json are refreshed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: LGTM once CI passes.
What was wrong: two new medium-severity Dependabot alerts (#27 and #28) were published for
brace-expansion. Expanding a pattern like{a},b}takes quadratic time, which allows a CPU denial of service. The lockfile had 1.1.18 (viaeslint → minimatch@3) and 5.0.9 (viatypescript-estree → minimatch@10).How it was fixed:
npm update brace-expansionmoves them to 1.1.21 and 5.0.12. Both are within their parents' ranges, so onlypackage-lock.jsonchanges. The threepackage-lock.jsonreceipts inscripts/quality-dependencies.jsonare refreshed. No source file changed.Proof:
npm ls brace-expansionnow shows 1.1.21 and 5.0.12.npm run lintpasses locally, and lint is the only thing that exercises these copies. Full CI is running on this PR.Notes: these are dev-only, so the shipped bundle is not affected. With #1 and #2, this clears every open Dependabot alert.
🤖 Generated with Claude Code