Adding Roe solver entropy fix and an exact Riemann solver#109
Open
orevans wants to merge 3 commits intoclawpack:masterfrom
Open
Adding Roe solver entropy fix and an exact Riemann solver#109orevans wants to merge 3 commits intoclawpack:masterfrom
orevans wants to merge 3 commits intoclawpack:masterfrom
Conversation
src/shallow_1D_py.py
Outdated
Member
There was a problem hiding this comment.
Can you add some continuations to these lines so they are not quite as long?
Member
|
Other than the comment above it would be nice to add a test for both Riemann solvers in PyClaw. |
ketch
added a commit
to ketch/pyclaw
that referenced
this pull request
Jan 28, 2016
Member
|
This fails on Travis because we don't have scipy installed there for the Riemann repo. We could add it, or simply move the import inside the roe solver function. I prefer the latter; @orevans could you please move that import? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.