Open
Conversation
mandli
force-pushed
the
new-pytest-test-runner
branch
from
63c061f to
0d9fb1a
Compare
This also required updating of the regression data as one of the gauges ended up having an extra time point due to unrelated changes. All differences were around 10^-16.
Requires a new argument to test runner build_executable to allow make variables in the command
This is an attempt to support adjoint testing without redoing each adjoint run twice and providing more stability and less fragility. A new helper function has been added to the AMRClaw test python module. Hopefully this will also work in GeoClaw.
mandli
force-pushed
the
new-pytest-test-runner
branch
from
0d9fb1a to
c2a9245
Compare
Member
Author
|
Turns out that some of the optimization flags are more sensitive that I had thought. All the tests are passing in the entire matrix now though! Note that for optimization flags that something more aggressive than |
Contributor
Member
Author
|
Yes, the tests themselves are susceptible to this, but in general this is not an issue. The adjoint tests seem to be the most sensitive, but the acoustics 2D radial problem also seems to have issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new
ClawpackTestRunnerto do testing. See clawpack/clawutil#187 for discussion and details.