Repository navigation
Draw the video app's header through AppNav, on @clawnify/app 0.4.8 - #95
Merged
Merged
Conversation
The app rendered <AppNav> only inside the dashboard and its own header otherwise, so outside the dashboard the SDK never mounted. Now one <AppNav> is used in both modes, with the header passed as `standalone`: the dashboard still draws the navigation, and a self-hosted copy draws the same header as before plus the SDK's "Built on Clawnify" dialog. The app has no sidebar of its own, so the sidebar card (`nav.card`) is not placed. Bumps @clawnify/app from 0.4.5 to 0.4.8; @clawnify/db was already on ^0.4.3, so one copy is installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<AppNav>was rendered only whenembedded, with the app's own header otherwise, so the SDK never mounted outside the dashboard. Now one<AppNav>is used in both modes and the header is itsstandalonerender: the dashboard behaviour is unchanged, and a self-hosted copy shows the same header plus the SDK's "Built on Clawnify" dialog. The app has no sidebar, sonav.cardis not placed. Theembeddedimport inapp.tsxis dropped.Bumps
@clawnify/appto 0.4.8.@clawnify/dbwas already^0.4.3, so a single copy is installed.Checks (before / after):
pnpm run build: pass / passpnpm test: 315 passed / 315 passedtsc --noEmit: 0 errors / 0 errors