Skip to content

Acceptance Process and Test Guidance - #244

Merged
geffzhang merged 4 commits into
nacosmcprouterfrom
main
Sep 19, 2026
Merged

geffzhang merged 4 commits into
nacosmcprouterfrom
main

Conversation

@geffzhang

Copy link
Copy Markdown
Collaborator

This pull request introduces a dedicated, reproducible Nacos/Router live acceptance workflow and updates the documentation to reflect the new acceptance process, NativeAOT SDK event support, and the current vendor-neutral adapter architecture. It clarifies the build flags for enabling Nacos and event adapters, describes the new acceptance harness, and replaces outdated historical instructions with guidance for the new test setup. Both English and Chinese documentation are revised for accuracy, including protocol details, event invalidation semantics, and clear separation of historical and current validation.

CI and Acceptance Harness

  • Added a new GitHub Actions workflow (.github/workflows/nacos-live.yml) to automate live acceptance tests for Nacos/Router integration, covering both managed and NativeAOT runtimes, including event invalidation and evidence upload.

Documentation: Build, Configuration, and Event Adapter

  • Updated all relevant docs to reflect that the Nacos Events adapter now supports both JIT and NativeAOT (not just JIT), and clarified the build flags (OpenClawEnableNacosEvents=true, with PublishAot=false for JIT). [1] [2] [3] [4]
  • Documented that the optional event adapter uses RedNb.Nacos 2.1.0 with source-generated protocol metadata, does not require JSON reflection, and is not included unless explicitly enabled. [1] [2] [3]

Acceptance Process and Test Guidance

  • Replaced historical live validation instructions with references to the new isolated acceptance harness, which provisions its own Nacos/Router/backend and validates both managed and NativeAOT event invalidation. Clarified that historical measurements are preserved for reference only. [1] [2] [3] [4] [5]
  • Updated Chinese documentation to match the new acceptance process, protocol details, and event invalidation semantics, and to clearly separate current validation from historical evidence. [1] [2] [3]

Protocol and Failure Handling Details

  • Clarified protocol argument/response structure, error normalization, and capability binding/execution behavior in both English and Chinese guides, including cache invalidation semantics and event-driven cache clearing. [1] [2] [3]

These changes ensure that the documentation and CI accurately reflect the current architecture, validation process, and event adapter capabilities, making it easier for contributors to understand and reproduce live acceptance.

Telli and others added 4 commits September 18, 2026 19:44
Co-authored-by: geffzhang <geffzhang@qq.com>
Co-authored-by: geffzhang <geffzhang@qq.com>
Co-authored-by: geffzhang <geffzhang@qq.com>
fix: enable NativeAOT Nacos events and verify live capability binding
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 3ff57ae8-718a-40c2-9f2a-edc76a404517

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@geffzhang
geffzhang merged commit 5a26df1 into nacosmcprouter Sep 19, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants