Skip to content

KeyboardEvents do not populate key field #497

Closed
Closed
KeyboardEvents do not populate key field#497

Description

@classilla
classilla
opened on Apr 25, 2018

http://jsfiddle.net/nobuoka/WjJKk/

char should remain undefined as per Firefox 59 on my MacBook, but we are not populating key (it appears Unidentified). The other fields look correct.

This is probably what's wrong with http://calormen.com/jsbasic/ and possibly Facebook.

Activity

  1. classilla commented on Apr 25, 2018

    @classilla
    classilla
    on Apr 25, 2018
    OwnerAuthor

    I don't think we're setting WidgetKeyboardEvent.mKeyNameIndex or WidgetKeyboardEvent.mCodeNameIndex in our code in widget/cocoa/nsChildView.mm since we don't use the TextInputHandler code.

  2. classilla commented on Apr 25, 2018

    @classilla
    classilla
    on Apr 25, 2018
    OwnerAuthor

    I think we want to patch convertCocoaKeyEvent: to add this.

  3. classilla
    added a commit that references this issue on Apr 27, 2018

    #497: improve DOM KeyboardEvent support

    d61e225

  4. classilla commented on Apr 30, 2018

    @classilla
    classilla
    on Apr 30, 2018
    OwnerAuthor

    Tested fully working on both sites.

  5. classilla
    closed this as completedon Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions