clar: define CLAR_MAX_PATH even w/o PATH_MAX#132
Merged
ethomson merged 1 commit intoclar-test:mainfrom Dec 30, 2025
Merged
Conversation
PATH_MAX is an optional constant in POSIX, and at least on GNU/Hurd it is not provided on purpose. Define CLAR_MAX_PATH to a static value in case PATH_MAX is not available, using the same value used for the "Windows with long paths" case. In the end, 4096 should not be a problem for a test framework.
Member
|
Thanks! Makes sense. |
Contributor
Author
|
@ethomson I see your update in libgit2/libgit2#7173 -- thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATH_MAXis an optional constant in POSIX, and at least on GNU/Hurd it is not provided on purpose.Define
CLAR_MAX_PATHto a static value in casePATH_MAXis not available, using the same value used for the "Windows with long paths" case. In the end, 4096 should not be a problem for a test framework.