fix: restore what the hosted demo merge dropped - #20
Merged
Merged
Conversation
#18 was merged after #19 and its conflicts were resolved in favour of #19 in three files, so main lost the Docker image job from CI, the changelog entries for serve --public, MCP over HTTP, and the Dockerfile, the README's link to docs/hosting.md, and M9's roadmap status. The code of both pull requests merged intact; these put the rest back as #18 had it.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores what was lost when #18 was merged after #19. Their conflicts in three files were resolved in favour of #19. The code of both pull requests merged intact, but main lost #18's CI job and docs. This puts them back exactly as #18 had them.
Changes
.github/workflows/ci.yml: the "Docker image" job again. It builds the demo image, starts it, and checks the web interface,/stats, and a tool call over/mcp. Main's CI had only thepython,package, andfalkordbjobs.CHANGELOG.md: the Unreleased entries forchatlore serve --public, MCP over HTTP at/mcp, and theDockerfile.README.md: the link todocs/hosting.md, in the same sentence as the FalkorDB guide, and M9's status: "public mode, MCP over HTTP, and Docker image done; deployment next".How it was tested
ruff,ruff format --check, strictmypy, andpytestpass on this branch: 323 passed. That is both pull requests' tests, including the 9 public-mode tests from feat(api): serve a public demo with question limits, MCP over HTTP, and a Docker image #18.ci.ymlparses, with the jobspython,package,docker, andfalkordb. The Docker job runs in this PR's CI for the first time on main's code, which now includes the FalkorDB store.Checklist
uv run ruff check .anduv run ruff format --check .passuv run mypypassesuv run pytestpassesCHANGELOG.mdupdated under Unreleased