Repository navigation
Group the All segment by leading bottle instead of by method - #125
Merged
Merged
Conversation
assets/app.js: leadBottle picks each drink's leading bottle from its build at boot (leadBy). A base spirit outranks vermouth and modifiers, the largest ounce pour wins within a rank, a tie goes to the first pour, and a drink with none of those kinds falls back to its first pour. menuSections is split into patternSections, bottleSections and methodSections; All renders one section per leading bottle in bar.json order with no blurb, and the method segments keep method then printed family. sectionHead omits the blurb paragraph when it is empty. assets/app.css: a drink directly under the section rule gets the same top margin as one under a blurb. scripts/app.test.mjs: cases for the leading bottle (So So Cocktail, Corpse Reviver No. 1, Vieux Carre, French 75, Bamboo, Bitter Giuseppe, a juice-only build), every drink appearing once under All, and Stirred keeping its family headings. CLAUDE.md: the Families section describes the All grouping and the rule behind it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The All segment on the Menu now lists drinks under the bottle each one is mostly made of, one heading per bottle in
bar.jsonorder, instead of Stirred / Shaken / Built with printed families under them. The method segments and Shapes are unchanged.Changes
assets/app.js:leadBottlepicks each drink's leading bottle from its build at boot (leadBy). A base spirit outranks vermouth and modifiers, the largest ounce pour wins within a rank, a tie goes to the first pour, and a drink with none of those kinds falls back to its first pour so it is never left off All.menuSectionsis split intopatternSections,bottleSectionsandmethodSections.sectionHeadomits the blurb when it is empty.assets/app.css: a drink directly under the section rule gets the same top margin as one under a blurb.scripts/app.test.mjs: cases for the leading bottle (So So Cocktail, Corpse Reviver No. 1, Vieux Carre, French 75, Bamboo, Bitter Giuseppe, a juice-only build), every drink appearing once under All, and Stirred keeping its family headings.CLAUDE.md: the Families section describes the All grouping and the rule.familyon the cocktail data is untouched. No ids, bits or link formats change.Headings on the full menu
Gin 49, Bourbon 21, Rye 18, Scotch 8, Cognac 12, Apple brandy 5, Aged rum 9, Light rum 14, Tequila 7, Vodka 11, Mezcal 6, Cachaça 5, Sweet vermouth 3, Dry vermouth 5, Campari 4, Absinthe 1, Cynar 1, Sherry 5, Fernet 1.
Checked
make verifypasses.main.Not checked
PRINT_SPLIT). Its weights still count every section heading as having a blurb, so the cut there may sit slightly off balance.