Repository navigation
Front page title and description, Menu h1, title and manifest drift checks - #123
Merged
Merged
Conversation
…hecks Title is now "few bottles: classic cocktails from a small home bar" in the title tag, og:title and twitter:title. The meta description, og and twitter descriptions, JSON-LD, README line one, humans.txt, llms.txt and the manifest now read "My printed menu, decoded. Tick what you have, see what you can pour tonight, and which bottle to buy next." "Cocktail maxxing on a budget." stays as the Info tab tagline only. The Menu view's sr-only h1 carries the proposition instead of "Menu"; the section's aria-label is still Menu. llms.py reads the llms-full.txt heading from the index.html title, and the dump's blockquote no longer repeats it. check_assets.py: check_title fails when og:title or twitter:title differs from the title tag, or the title is missing; check_description now covers the manifest description. Four cases added to test_checks.py. Closes #113. Closes #99.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title is now "few bottles: classic cocktails from a small home bar" in the title tag, og:title and twitter:title. The meta description, og and twitter descriptions, JSON-LD, README line one, humans.txt, llms.txt and the manifest now read "My printed menu, decoded. Tick what you have, see what you can pour tonight, and which bottle to buy next." "Cocktail maxxing on a budget." stays as the Info tab tagline only.
index.html: title, og and twitter titles and descriptions, JSON-LD description; the Menu view's sr-only h1 reads "Classic cocktails from a small home bar" (the section's aria-label is still Menu).scripts/llms.py: the llms-full.txt heading is read from the index.html title; its blockquote no longer repeats the heading.scripts/check_assets.py:check_titlefails when og:title or twitter:title differs from the title tag, or the title is missing;check_descriptionnow covers the manifest description.scripts/test_checks.py: four cases for the new checks, each confirmed to fail with its check disabled.make verifypasses. Not checked: a browser pass (nothing visible on screen changed), the title in a search result or an unfurl preview.Closes #113. Closes #99.