Repository navigation
Stop deploys from resetting the ECS task count set by the autoscaler - #601
Draft
chelseakr-exygy wants to merge 1 commit into
Draft
chelseakr-exygy wants to merge 1 commit into
chelseakr-exygy wants to merge 1 commit into
Conversation
chelseakr-exygy
marked this pull request as ready for review
October 6, 2026 21:10
chelseakr-exygy
marked this pull request as draft
October 6, 2026 21:12
Member
Author
|
forgot to perform manual testing, stand by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every
bin/deployset the ECS service back toFARGATE_DESIRED_TASK_COUNT, draining tasks the autoscaler had added. The service now ignores later changes todesired_count, so the value only sets the starting count.Behavior change: setting
FARGATE_DESIRED_TASK_COUNT=0and redeploying no longer shuts the server down. Useaws ecs update-service --desired-count <n>. The variable description is updated, and civiform-deploy's example config needs a follow-up.This is a technical change to the deployment infrastructure only. There's no change to CiviForm itself and nothing for QA to test.
Code written with AI assistance (Claude), PR body written by human!
Checklist
General
civiform/deployment-systembin/setupwithout your changes and thenbin/deploywith your changes to ensure your changes don't break existing deployments)Instructions for manual testing
Technical check for the deployment reviewer, not a QA task. Not yet run in AWS.
bin/setupandbin/deployon main withFARGATE_DESIRED_TASK_COUNT=1.aws ecs update-service --cluster <cluster> --service <service> --desired-count 3.bin/deployfrom this branch. The plan should show nodesired_countchange, and the service should stay at 3 tasks through the rollout.FARGATE_DESIRED_TASK_COUNT=2and deploy again. No change should be proposed.Issue(s) this completes
Fixes civiform/civiform#14017