Repository navigation
Move civiform container/task definition to its own module - #600
Merged
Merged
Conversation
salg-r
marked this pull request as ready for review
October 2, 2026 00:47
chelseakr-exygy
approved these changes
Oct 5, 2026
chelseakr-exygy
left a comment
chelseakr-exygy
left a comment
Member
There was a problem hiding this comment.
Looks good, approving! Every resource that moved has a moved block, and the task definitions come out unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new module in cloud/aws/modules/civiform_app/. It contains AWS ECS task and container definitions for civiform that used to live in cloud/aws/templates/aws_oidc/app.tf. This change makes it easier for an external configuration to reuse civiform's container and task definitions using a diferent AWS ECS config.
Checklist
General
civiform/deployment-systembin/setupwithout your changes and thenbin/deploywith your changes to ensure your changes don't break existing deployments)Instructions for manual testing
Tested by running bin/deploy before and after this change and causing no changes in an existing deployment.