Fix missing Dockerfile base image#109
Closed
hegelocampus wants to merge 1 commit into
Closed
Conversation
Update Dockerfile to use an actively maintained base image.
hegelocampus
changed the title
Member
|
Addressed via PR #110 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes /issues/108 by updating the Dockerfile to use an actively maintained base image, the old image was deprecated and no longer available.
Description
This updates the base image to a new, currently maintained base image that provides the needed jdk.
I verified this fix works by running
docker run -v HOST_DEFINITIONS_PATH:/definitions test_telemetry_generator:localand the docker container builds and runs now, as expected (was previously broken).Type of Change
Checklist