Adjust job configurations in the build workflow#180
Merged
Conversation
mcdonnnj
added
the
improvement
github-actions
Bot
added
the
github-actions
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions build workflow job configuration to use clearer job IDs and to adjust job dependencies so wheel building is attempted regardless of source test outcome, while wheel testing is gated on successful source testing and wheel builds.
Changes:
- Renamed workflow jobs (
test→test-source,build→build-wheel,test-build→test-wheel). - Updated
needs:dependencies sobuild-wheelruns afterdiagnosticsonly, andtest-wheelrequires bothbuild-wheelandtest-source. - Updated downstream dependencies to reference the renamed jobs (e.g.,
coveralls-finishnow needstest-source).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsf9k
approved these changes
Feb 7, 2026
github-project-automation
Bot
moved this from In progress
to Reviewer approved
in Skeleton Maintenance
mcdonnnj
added
the
kraken 🐙
Remove the dependency on the `lint` job from the `build` job. Since we do not depend on the success of the `lint` job to test the source code I don't see a reason we need to depend on it to (try to) build a wheel as long as the `diagnostics` job completes successfully). Also remove the dependency on the `test` job from the `build` job and add it to the `test-build` job. This will allow us to attempt to build wheels for the project even if source code testing has not (yet) passed, but will not bother testing the built wheel unless source code testing has passed.
Adjust the names of several jobs to more clearly align with their descriptive names and functionality. Any dependencies are also updated to use the new names.
jsf9k
force-pushed
the
improvement/adjust_build_workflow
branch
from
5e31562 to
842c518
Compare
github-project-automation
Bot
moved this from Reviewer approved
to Done
in Skeleton Maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adjust the job configurations in the
buildworkflow by renaming some jobs and adjusting job dependencies.💭 Motivation and context
Job names are changed to better align with their descriptive names and their respective functionality. Dependencies are modified so that the workflow attempts to build wheels no matter what, but testing those wheels is only done if it is able to successfully test the source (and wheels have been built successfully).
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist