Separate Coveralls build results by platform#156
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Coveralls integration to use unique flag names that include both Python version and platform information, addressing issues with parallel test result processing across multiple platforms.
- Modified the
flag-nameparameter in the Coveralls GitHub Action to include platform information alongside Python version - This ensures unique identifiers for each test run combination, preventing namespace collisions in Coveralls reporting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3 tasks
jsf9k
approved these changes
Sep 22, 2025
dv4harr10
approved these changes
Sep 22, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
Separate Coveralls build results by platform
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 22, 2025
Separate Coveralls build results by platform
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
Separate Coveralls build results by platform
Currently we only set the flag for build results to the Python version, but since we test across platforms now we should also separate by the platform as well.
7f4d2a4 to
f063840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the flag used for Coveralls test results to include the platform and not just the Python version.
💭 Motivation and context
The description for using Coveralls in parallel such as we do indicated that the
flag-namevariable must be unique. Since we have started multi-platform testing that has not been the case and it appears to be causing problems in getting Coveralls test results reported. This appears to rectify the issue.🧪 Testing
Automated tests pass. I verified that Coveralls appears to be processing the test results whereas before it seemed unable to process the uploaded files (likely because of namespace collision).
✅ Pre-approval checklist