Skip to content

Use official terraform-docs releases again#263

Open
mcdonnnj wants to merge 1 commit into
developfrom
improvement/use_standard_terraform-docs_releases_again
Open

Use official terraform-docs releases again#263
mcdonnnj wants to merge 1 commit into
developfrom
improvement/use_standard_terraform-docs_releases_again

Conversation

@mcdonnnj

Copy link
Copy Markdown
Member

🗣 Description

This pull request restores using official terraform-docs releases in the build workflow. This resolves #165.

💭 Motivation and context

With the merge of my two feature branches into the terraform-docs repository and the new 0.22.0 release we can start using official releases again.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

The changes we need were merged and a new release including them was
cut. As a result we can resume installing terraform-docs from the
official repository.
@mcdonnnj mcdonnnj self-assigned this Apr 13, 2026
@mcdonnnj mcdonnnj requested review from dav3r, felddy and jsf9k as code owners April 13, 2026 13:38
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Apr 13, 2026
@mcdonnnj mcdonnnj requested a review from Copilot April 13, 2026 13:38
@github-actions github-actions Bot added the github-actions Pull requests that update GitHub Actions code label Apr 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the CI build workflow to use the upstream terraform-docs project again (via versioned installs) rather than building from a temporary fork/branch, resolving the earlier workaround tracked in issue #165.

Changes:

  • Removed fork/branch environment variables used to clone a temporary terraform-docs fork.
  • Replaced the clone+local build steps with a go install of terraform-docs at the version provided by setup-env.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jsf9k

jsf9k commented Apr 13, 2026

Copy link
Copy Markdown
Member

Doesn't this resolve #165? You should add that to the description so the issue gets closed.

@mcdonnnj

Copy link
Copy Markdown
Member Author

Doesn't this resolve #165? You should add that to the description so the issue gets closed.

That was already mentioned in the description and linked.

@jsf9k

jsf9k commented Apr 13, 2026

Copy link
Copy Markdown
Member

Doesn't this resolve #165? You should add that to the description so the issue gets closed.

That was already mentioned in the description and linked.

Sorry, I somehow missed that. I usually put it in the motivation section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release

Projects

Status: Reviewer approved

Development

Successfully merging this pull request may close these issues.

TODO: Revert back terraform-docs repo

4 participants