Remove the bandit configuration file#253
Merged
Merged
Conversation
The file is not used to configure anything bandit does by default so we can safely remove it and updated the pre-commit configuration. This is also acceptable because the configuration file has been removed downstream in cisagov/skeleton-python-library already.
mcdonnnj
added
the
improvement
github-actions
Bot
added
the
dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an effectively no-op Bandit configuration file and updates repository automation to stop referencing it, aligning this repo with the downstream skeleton changes.
Changes:
- Remove
.bandit.ymlfrom the repository. - Update the Bandit pre-commit hook to stop passing
--config=.bandit.yml. - Update GitHub labeler rules to stop matching
.bandit.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Removes Bandit hook args that referenced the deleted config file. |
.github/labeler.yml |
Removes .bandit.yml from the test label globs. |
.bandit.yml |
Deletes the unused Bandit configuration file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
jsf9k
approved these changes
Mar 10, 2026
dav3r
approved these changes
Mar 11, 2026
github-project-automation
Bot
moved this from In progress
to Reviewer approved
in Skeleton Maintenance
Member
|
@mcdonnnj - Are you going to create the PR for cisagov/skeleton-aws-lambda-python? |
Member
Author
I assumed the change could be made when this PR's changes roll down. |
github-project-automation
Bot
moved this from Reviewer approved
to Done
in Skeleton Maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request removes the bandit configuration file (
.bandit.yml) and updates the pre-commit configuration accordingly.💭 Motivation and context
The configuration file does not do any configuring and it has been removed downstream in cisagov/skeleton-python-library#164.
Note
The same changes made around the bandit configuration file in cisagov/skeleton-python-library#164 should be made to cisagov/skeleton-aws-lambda-python.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist