add DBType instance for Aeson.Object#395
Merged
TeofilC merged 2 commits intocircuithub:masterfrom Mar 12, 2026
Merged
Conversation
Contributor
Author
|
Sorry, the Nix build was taking ages, so I crossed my fingers. I'll force push this with a fix in a bit. |
Contributor
|
I think CI might just be broken independently of your changes. I'll resolve that soon |
TeofilC
approved these changes
Mar 11, 2026
Contributor
Author
|
It did fail on my change: I mixed up a type, |
raehik
force-pushed
the
dbtype-aeson-object
branch
from
00c7797 to
00b2abc
Compare
Contributor
Author
|
I added a test in the appropriate place too. I haven't double checked it locally, but CI is happy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Piggybacks off of the existing
instance DBType Aeson.Value. Uses Aeson's parse failure message directly. Closes #394 .