Skip to content

fix(scripts): salience_phase0.sh — flyctl ssh -C is exec, not shell #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cipher813 merged 1 commit into from
May 22, 2026
Merged

fix(scripts): salience_phase0.sh — flyctl ssh -C is exec, not shell #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions scripts/salience_phase0.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,16 @@ cmd_snapshot() {
echo_ok "remote /tmp/snap.sqlite written"

echo_step " Step 2/4 — vecstore copy on Fly (numpy savez is atomic)"
flyctl ssh console -a "$FLY_APP" -C \
"cp /data/default.vec.npz /tmp/snap.vec.npz && echo 'vec copy done'" \
|| echo_warn "remote vecstore copy failed — embedding signals will be zero"
echo_ok "remote /tmp/snap.vec.npz written"
# flyctl ssh -C does NOT spawn a shell — it execs the command directly,
# so shell operators like `&& echo X` get passed as literal cp args
# (caught 2026-05-21: cp tried to use "vec copy done" as a destination).
# Single command only. If we need chaining, wrap in `sh -c "..."`.
if flyctl ssh console -a "$FLY_APP" -C \
"cp /data/default.vec.npz /tmp/snap.vec.npz"; then
echo_ok "remote /tmp/snap.vec.npz written"
else
echo_warn "remote vecstore copy failed — embedding signals will be zero"
fi

echo_step " Step 3/4 — sftp download (sqlite + vec.npz)"
rm -f "$SNAPSHOT_PATH" "$VEC_PATH"
Expand All @@ -100,9 +106,11 @@ cmd_snapshot() {
fi

echo_step " Step 4/4 — clean up remote temp files"
flyctl ssh console -a "$FLY_APP" -C "rm -f /tmp/snap.sqlite /tmp/snap.vec.npz" \
|| echo_warn "remote cleanup failed (harmless — /tmp churns on machine restart)"
echo_ok "remote /tmp files removed"
if flyctl ssh console -a "$FLY_APP" -C "rm -f /tmp/snap.sqlite /tmp/snap.vec.npz"; then
echo_ok "remote /tmp files removed"
else
echo_warn "remote cleanup failed (harmless — /tmp churns on machine restart)"
fi

# Quick sanity: count live memories + verify vec.npz is loadable
local live_count vec_count
Expand Down
Loading