fix(archive): persist consolidated_report to S3 — closes 2-month dashboard archive stale

[cipher813]

Summary

archive_writer was building the weekly consolidated brief into state.consolidated_report, handing it off to email_sender for the morning email, and then dropping it. ArchiveManager.save_consolidated_report() existed but had no caller anywhere in the codebase — the persistence wire to s3://alpha-engine-research/consolidated/{date}/morning.md was lost.

Evidence of the wiring loss: last morning.md write to S3 was 2026-03-16. Every week since (~10 runs) emailed the brief to the user but never persisted it. The dashboard's Research Briefing Archive page was correctly showing the last actually-persisted artifact — that's why "Latest" displayed 2026-03-16 while EOD emails kept landing in the same date partition.

$ aws s3 ls s3://alpha-engine-research/consolidated/2026-05-20/
2026-05-20 13:27:38   6849 eod.html       # ← still written
                                          # ← morning.md missing

Fix

3 lines in archive_writer right next to write_signals_json, same try/except shape so a save failure doesn't block the rest of the archive pipeline.

consolidated = state.get("consolidated_report", "") or ""
if consolidated:
    try:
        am.save_consolidated_report(run_date, consolidated)
    except Exception as e:
        logger.error("Failed to save consolidated_report: %s", e)

Tests

• test_save_consolidated_report_writes_morning_md_to_s3 — pins the producer side: save_consolidated_report("2026-05-20", brief) writes one put_object call with Key=consolidated/2026-05-20/morning.md and the brief body.
• test_archive_writer_wires_save_consolidated_report — structural pin via inspect.getsource(archive_writer). If the wiring is dropped again, this fails at CI time instead of silently staling the archive surface for two months.
• 1375/1375 suite green.

Backfill

Historical 2026-03-16 → 2026-05-17 gap can't be backfilled — those briefs were emailed only, not retained anywhere else. Next Saturday SF research run (2026-05-23) populates the first new morning.md and the archive page surfaces it the next time the dashboard refreshes its cache (TTL 15 min).

🤖 Generated with Claude Code