Skip to content

fix(freshness-deploy): use file:// for historical-cron put-targets #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cipher813 merged 2 commits into from
May 28, 2026
Merged

fix(freshness-deploy): use file:// for historical-cron put-targets #343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b9906c
fix(freshness-deploy): use file:// for historical-cron put-targets
cipher813 May 28, 2026
212a515
Merge branch 'main' into fix/freshness-deploy-historical-target-json
cipher813 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion infrastructure/lambdas/freshness-monitor/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,26 @@ if $BOOTSTRAP; then
--region "${REGION}" \
--query 'RuleArn' --output text

# JSON Input (`{"mode":"historical"}`) doesn't fit the put-targets
# shorthand form (Id=,Arn=,Input= chokes on the embedded quotes +
# comma). Write a temp JSON file + pass via file:// to dodge the
# shell-quoting trap. Caught live 2026-05-28 when --bootstrap re-run
# tripped argparse on the shorthand.
HIST_TARGET_JSON=$(mktemp)
cat > "${HIST_TARGET_JSON}" <<EOF
[
{
"Id": "1",
"Arn": "${FN_ARN}",
"Input": "{\"mode\":\"historical\"}"
}
]
EOF
run aws events put-targets \
--rule "${HISTORICAL_RULE_NAME}" \
--targets "Id=1,Arn=${FN_ARN},Input={\"mode\":\"historical\"}" \
--targets "file://${HIST_TARGET_JSON}" \
--region "${REGION}"
rm -f "${HIST_TARGET_JSON}"

HIST_RULE_ARN="arn:aws:events:${REGION}:${ACCOUNT_ID}:rule/${HISTORICAL_RULE_NAME}"
run aws lambda add-permission \
Expand Down
Loading