refactor(changelog-incident-mirror): smoke test migrates to alpha_engine_lib.alerts CLI#277
Merged
Conversation
…ine_lib.alerts CLI Per ROADMAP L146 (SOTA / institutional-approach sub-sub-rule). Second inline-alerts site named in the ROADMAP — sibling PR alpha-engine #200 migrates the alpha-engine/infrastructure/health_checker.sh half. infrastructure/lambdas/changelog-incident-mirror/deploy.sh: raw `aws sns publish` → `python -m alpha_engine_lib.alerts publish`. SNS target stays identical (default `alpha-engine-alerts` topic resolution), so the changelog-incident-mirror Lambda still receives the message and the smoke test still verifies end-to-end. `--no-telegram` keeps the deliberate-per-deploy noise off the operator channel; `severity=info` matches the smoke-test semantics. Lib pin v0.20.0 → v0.21.0 in BOTH requirements.txt AND Dockerfile (lockstep, per the test_lib_pin_lockstep regression test). v0.21.0 is the alerts-module floor; v0.20 → v0.21 is additive (just the alerts module). Suite: 1401 passed (vs 1400 baseline — lib v0.21 doesn't break any existing consumer). Closes alpha-engine-data half of ROADMAP L146 (P2). After both PRs merge, `grep -rE "aws sns publish.*alpha-engine-alerts|api.telegram.org/bot" infrastructure/ deploy/ --include="*.sh"` returns zero hits across both alpha-engine and alpha-engine-data. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infrastructure/lambdas/changelog-incident-mirror/deploy.shsmoke path: rawaws sns publish→python -m alpha_engine_lib.alerts publish --severity info --no-telegram --source alpha-engine-data/changelog-incident-mirror/deploy.sh. SNS target topic unchanged (defaultalpha-engine-alertsresolution); Lambda receives the message; smoke test still validates end-to-end.--no-telegram+severity=infokeep the per-deploy smoke off the operator channel (this is a deliberate test injection, not a failure event).requirements.txtANDDockerfile(lockstep — thetest_lib_pin_lockstepregression test enforces this). v0.21.0 is the alerts-module floor.Why
ROADMAP L146 / SOTA sub-sub-rule (lift-to-lib for ≥2 consumers). First consumer was alpha-engine-backtester #231; this and PR #200 complete the two-site pass.
Test plan
test_lib_pin_lockstepvalidates Dockerfile/requirements.txt agree).alpha_engine_lib.alertsimports.--no-sns --no-telegramreturns the expected status string.deploy.sh --smokelands a record ins3://alpha-engine-research/changelog/entries/{date}/within ~3s with no Telegram ping.grep -rE "aws sns publish.*alpha-engine-alerts|api.telegram.org/bot" infrastructure/ --include="*.sh"across alpha-engine + alpha-engine-data returns zero hits.🤖 Generated with Claude Code