PR4 (backtester, DRAFT): exit_timing slim leg + dead spot-sync removed [merge-gated 5/23]#227
Draft
cipher813 wants to merge 1 commit into
Draft
PR4 (backtester, DRAFT): exit_timing slim leg + dead spot-sync removed [merge-gated 5/23]#227cipher813 wants to merge 1 commit into
cipher813 wants to merge 1 commit into
Conversation
…leted PR4 (backtester) of the predictor/price_cache_slim deletion arc — TERMINAL state. DRAFT, merge-gated on the 5/23 parity read (same gate as data #269; see that PR's WAVE4_SLIM_DELETION_RUNBOOK.md). - analysis/exit_timing._load_price_cache: drop the predictor/ price_cache_slim parquet leg + the slim<->ArcticDB parity dual-read block. ArcticDB universe lib stays primary; predictor/price_cache (10y full parquet — Wave-3 scope, untouched) is the sole fallback. reconcile import removed (only the parity block used it). - infrastructure/spot_backtest.sh: delete the verified-dead 'aws s3 sync predictor/price_cache_slim/ -> data/cache' (task #8: predictor_backtest loads from ArcticDB via load_universe_from_arctic; the ONLY data/cache read is sector_map.json via the SEPARATE 'aws s3 cp .../price_cache/sector_map.json' line, which is Wave-3's price_cache/ scope and is KEPT). Comment/echo updated to match. - test_exit_timing: the 3 PR2 slim/parity tests reworked to terminal state (no slim leg, no parity emit, price_cache-only fallback); unused _capture_logs helper removed. No lib pin change (backtester already v0.20.0 from PR2; the test_flow_doctor_wiring stable-tag assertion is unaffected). Full backtester suite 1687 passing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT — merge-gated on the 2026-05-23 Saturday-SF parity read (same gate as data #269; see its
WAVE4_SLIM_DELETION_RUNBOOK.md). Terminal PR of the Wave-4 arc, backtester side.Changes
analysis/exit_timing._load_price_cache— drop thepredictor/price_cache_slimparquet leg + the slim↔ArcticDB parity dual-read. ArcticDB universe lib stays primary;predictor/price_cache(10y) is the sole fallback (Wave-3's scope — untouched here).reconcileimport removed (only the parity block used it).infrastructure/spot_backtest.sh— delete the verified-deadaws s3 sync predictor/price_cache_slim/ → data/cache. Task-Split evaluation into independent entry point #8 verification (code-level, not a stale-ROADMAP claim):synthetic/predictor_backtest.pyloads prices+features from ArcticDB (load_universe_from_arctic); the onlydata/cache/read issector_map.jsonvia the separateaws s3 cp .../price_cache/sector_map.jsonline — which is kept (Wave-3'sprice_cache/scope). No code globsdata/cache/*.parquet.test_exit_timing— the 3 PR2-added slim/parity tests reworked to the terminal state (no slim leg, no parity emit,price_cache-only fallback); unused_capture_logshelper removed.Safety
v0.20.0from PR2 PR2: exit_timing → ArcticDB-primary (slim parity + price_cache fallback) #226; thetest_flow_doctor_wiringstable-tag assertion is unaffected).Gate
Do not merge until the 5/23 Saturday-SF
WAVE4_PARITY_METRIC {breadth,compute,exit_timing}streams confirm slim↔ArcticDB equivalence (pass / max_abs_value_delta ≈ 0 / noonly_in_b). Merging this before then removes the slim leg that still feeds theexit_timingparity evidence.🤖 Generated with Claude Code